Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mailer for on-boarding newcomer #3025

Merged
merged 6 commits into from
Jul 10, 2018
Merged

Mailer for on-boarding newcomer #3025

merged 6 commits into from
Jul 10, 2018

Conversation

grvsachdeva
Copy link
Member

Fixes #2241

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@ghost ghost assigned grvsachdeva Jul 10, 2018
@ghost ghost added the in progress label Jul 10, 2018
@grvsachdeva grvsachdeva mentioned this pull request Jul 10, 2018
Closed
@plotsbot
Copy link
Collaborator

plotsbot commented Jul 10, 2018 •
edited
Loading

1 Message
📖 @Gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Looks like it needs a restart - you can close/open the PR to restart it - doing this now...

@jywarren
Copy link
Member

oh i see it's already been restarted, thanks!!!

@grvsachdeva grvsachdeva requested a review from jywarren July 10, 2018 15:39
@jywarren
Copy link
Member

This looks great - maybe a simple test too?

@jywarren jywarren merged commit 2fd9e45 into publiclab:master Jul 10, 2018
@ghost ghost removed the in progress label Jul 10, 2018
@jywarren
Copy link
Member

Hooray!!!

@grvsachdeva grvsachdeva mentioned this pull request Jul 11, 2018
Closed
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@grvsachdeva @jywarren
Mailer for on-boarding newcomer (publiclab#3025)
8c2aef0 
* new helper function for node

* mailer created

* name typo

* fixtures

* test added

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren Awaiting requested review from jywarren

Assignees

@grvsachdeva grvsachdeva

Labels
ready summer-of-code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email for welcoming newcomer at time of Sign up
3 participants
@grvsachdeva @plotsbot @jywarren