Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added remaining unit tests for #2933 #3020

Merged
merged 5 commits into from
Jul 12, 2018
Merged

Added remaining unit tests for #2933 #3020

merged 5 commits into from
Jul 12, 2018

Conversation

namangupta01
Copy link
Member

@namangupta01 namangupta01 commented Jul 9, 2018 •
edited
Loading

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
Closes #3019

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@ghost ghost assigned namangupta01 Jul 9, 2018
@ghost ghost added the in progress label Jul 9, 2018
@namangupta01 namangupta01 requested a review from jywarren July 9, 2018 21:05
@plotsbot
Copy link
Collaborator

plotsbot commented Jul 9, 2018 •
edited
Loading

2 Messages
📖 @namangupta01 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

jywarren
jywarren reviewed Jul 9, 2018
View reviewed changes
test/incoming_test_emails/gmail/trimmed_content.txt Outdated
@@ -0,0 +1,9 @@
On Tue, Jul 3, 2018 at 11:17 PM Naman Gupta \<[01namangupta@gmail.com](mailto:01namangupta@gmail.com)\> wrote:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files could go in /test/fixtures/ maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so should i also move final_parsed_comment.txt there so that all three files could be at the same place or i move only two files there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think any "example" content for the purpose of testing could go in
/fixtures/ -- thanks!

@jywarren
Copy link
Member

jywarren commented Jul 9, 2018

Nice tests!!!

@jywarren
Copy link
Member

jywarren commented Jul 9, 2018

Hey @namangupta01 has the gmail trimming filter been working for you?

@namangupta01
Copy link
Member Author

Yes i tried on https://publiclab.org/notes/namangupta/02-17-2018/gsoc-proposal, it was working there.

@namangupta01
Copy link
Member Author

@jywarren I just tried to comment on https://publiclab.org/notes/namangupta/02-17-2018/gsoc-proposal but reply didn't get posted? Can you check the logs?

@namangupta01
Copy link
Member Author

Is the mailman server timeouts?

@jywarren
Copy link
Member

jywarren commented Jul 9, 2018

Moving to #3022 !! Thanks!

@namangupta01
Copy link
Member Author

@jywarren It's now good to merge?

@jywarren jywarren merged commit 3c79545 into publiclab:master Jul 12, 2018
@ghost ghost removed the in progress label Jul 12, 2018
@jywarren
Copy link
Member

Awesome!!!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@namangupta01 @jywarren
Added remaining unit tests for publiclab#2933 (publiclab#3020)
c31b7f6 
* Added remaining unit tests for publiclab#2933

* Minor change

* Indentation changed

* Added tests and moved emails to fixtures

* Added tests and moved emails to fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren left review comments

Assignees

@namangupta01 namangupta01

Labels
summer-of-code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for the functions in #2933
3 participants
@namangupta01 @plotsbot @jywarren