Changing jasmine tests to teaspoon-mocha #2997

Souravirus · 2018-07-06T14:23:48Z

Fixes #2967
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
PR body includes fixes #0000-style reference to original issue #
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

plotsbot · 2018-07-06T14:32:19Z

	2 Messages
📖	@Souravirus Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

Souravirus · 2018-07-08T19:20:48Z

spec/javascripts/plots2_spec.js


-    });

    $('#like-button-1').trigger('click');


Hi @jywarren, some help required here. I was trying to make this action work but its not calling the ajax function but in jasmine it was calling the ajax function. So, all the expect statement are failing.

Souravirus · 2018-07-08T19:21:20Z

spec/javascripts/plots2_spec.js


    $('#like-button-1').trigger('click');

    // should trigger the following and our ajaxSpy should return a fake response of "4":
-    // jQuery.getJSON("/likes/node/1/create", {}, function() { ...
+    var response;
+    jQuery.getJSON("/likes/node/1/create").done(function(data){


While this function is calling the ajax function correctly which is being stubbed above.

Souravirus · 2018-07-09T12:23:44Z

spec/javascripts/inline_grids_spec.js


-    expect($($('.notes-grid tr')[1]).find('td:first a').html()).toEqual('First post');
+    expect($($('.notes-grid tr')[1]).find('td:first a').html()).to.eql('First post');

    $('table:first th:first a').trigger('click');

    setTimeout(0, function() {


Hi @jywarren, can I know why we used setTimeout here. Can't we test this without it?

jywarren · 2018-07-09T14:52:34Z

I believe it was to bump the test to the bottom of the asynchronous queue, to be sure it executes after other asynchronous threads. You can try but it may not be as deterministic... but give it a try!

…

On Mon, Jul 9, 2018 at 8:24 AM Sourav Sahoo ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In spec/javascripts/inline_grids_spec.js <#2997 (comment)>: > - expect($($('.notes-grid tr')[1]).find('td:first a').html()).toEqual('First post'); + expect($($('.notes-grid tr')[1]).find('td:first a').html()).to.eql('First post'); $('table:first th:first a').trigger('click'); setTimeout(0, function() { Hi @jywarren <https://github.com/jywarren>, can I know why we used setTimeout here. Can't we test this without it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2997 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwaOiY9q8NBG3epM1ehPqmUxHyv4ks5uE0tRgaJpZM4VFiwn> .

Souravirus · 2018-07-09T15:52:27Z

oh ok thanks!!

Souravirus · 2018-07-10T16:26:10Z

Hi @jywarren, I don't know why but the travis tests are not running here. What might be the reason?

Souravirus · 2018-07-10T16:26:59Z

It was running on the third-last commit.

Souravirus · 2018-07-10T16:56:16Z

its working now

Souravirus · 2018-07-10T18:35:12Z

Hi @jywarren this is complete. Please review it

jywarren · 2018-07-11T19:16:29Z

This is great. I'd like to ask if another @publiclab/soc member could try installing this and running tests, as the phantomjs gem has caused me trouble in the past -- does it go smoothly?

Second, let's think about documentation of this in the TESTING docs?

Third, do you want to try introducing a JavaScript error and/or test failure and show what happens, in this PR? We can then resolve it and see that it resolves too. I'm thinking of how it'll be represented -- would Dangerbot be able to see it? Even if not, will it be clearly visible in the Travis log, and we could make an integration later to display it in a comment?

Thank you!!!

Souravirus · 2018-07-11T19:23:04Z

yeah this goes smoothly as far as I have tested it. It would be nice if someone from @publiclab/soc could try installing this.

yeah I would write documentation about it. Any help would be greatly appreciated.

About the representation of the error in Dangerbot. Not Dangerbot doesn't shows any error but travis tests don't pass and it shows red.

Souravirus · 2018-07-11T19:32:37Z

I guess I have to work for showing the errors in Dangerbot. I have to study about dangerbot to get it working. Thanks!!

jywarren · 2018-07-11T19:34:30Z

There may be other ways to show errors too, besides Dangerbot! Maybe Travis can generate messages?

…

On Wed, Jul 11, 2018 at 3:33 PM Sourav Sahoo ***@***.***> wrote: I guess I have to work for showing the errors in Dangerbot. I have to study about dangerbot to get it working. Thanks!! — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#2997 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ4uGS6FUP3D8YARYXEwb-0YkX4zOks5uFlLWgaJpZM4VFiwn> .

Souravirus · 2018-07-11T19:35:45Z

Yeah just see how it works I have created an intentional error.

Souravirus · 2018-07-11T19:44:27Z

Hmm dangerbot doesn't shows any error but travis shows an error. That's what I was talking about. What do you think?

jywarren · 2018-07-17T22:23:08Z

.travis.yml

@@ -27,6 +27,7 @@ install:

 script:
  - docker-compose exec web bash -c "CI=TRUE GENERATE_REPORT=true rake test:all"
+  - cat ./spec/TEST-Teaspoon-Result.xml >> output2.xml


Should maybe this be unnecessary since anything starting with TEST and ending with .xml will get compiled into output.xml?

jywarren · 2018-07-17T22:23:45Z

Dangerfile

@@ -27,8 +27,12 @@ end

 message "Pull Request is marked as Work in Progress" if github.pr_title.include? "[WIP]"

+junit.parse "output2.xml"


ah ok. But then you could skip this part and have the original tests put in /spec/TEST-Teaspoon-Result.xml right?

Ok I will directly parse /spec/TEST-Teaspoon-Result.xml

jywarren · 2018-07-17T22:25:59Z

Hi, I think you may need to do puts or cat spec/TEST____.xml in order to read the output manually and see what it generates. I think there is also an issue with Danger reading the failures that has come up from time to time.

Either we should work on getting Danger to properly read and report the Junit tests, OR we should come up with another mechanism (maybe another bot?) to get Junit test reports (or anything from Travis) to be reported back.

If you end up using Jasmine, there are Junit reporters here: https://github.com/larrymyers/jasmine-reporters

There's some on Teaspoon and reports in CI here: https://github.com/jejacks0n/teaspoon#ci-support

jywarren · 2018-07-17T22:27:17Z

I guess I think debugging Danger's reading of Junit failures is probably the best route. I think you could try to debug by outputting the compiled junit tests and trying to read them in the logs manually, as painstaking as that sounds.

Souravirus · 2018-07-18T02:06:19Z

Ok I will try one of these especially the teaspoon ci reporter. Let's see how it works. But currently I am travelling back to my college. So, I will be fully available tomorrow.

jywarren · 2018-07-18T14:13:51Z

OK!

…

On Tue, Jul 17, 2018 at 10:06 PM Sourav Sahoo ***@***.***> wrote: Ok I will try one of these especially the teaspoon ci reporter. Let's see how it works. But currently I am travelling back to my college. So, I will be fully available tomorrow. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2997 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ--qh7xihT_Nwsrr0HfrMQzFHe4eks5uHpgcgaJpZM4VFiwn> .

Souravirus · 2018-07-20T20:14:56Z

Hi @jywarren, I have reverted all the changes related to reporting of the failures. Review this once. I will be submitting the reporting fix in another PR. Thanks!!

jywarren · 2018-07-20T20:23:28Z

Great - so if a test fails, this will show a failure, but just as an X, without reporting, right? Or will JavaScript errors not trigger a Travis failure? Thanks!

Souravirus · 2018-07-20T20:28:21Z

No travis will show a X, without reporting

jywarren · 2018-07-20T20:29:01Z

Perfect! Merged! 🎉

* Changed jasmine tests to teaspoon-mocha * Few corrections * Corrected inline_grids_spec.js * Some changes in first test of plots2_spec.js * Made the first expect work * made the click function above the jquery function in plots_spec * Corrected the wikis_spec.js * Corrected all tests in plots2_spec.js * Corrected the Gemfile * Running the rake test:all in Rakefile * Corrected the rubocop offenses * Corrected some identation problem in .travis.yml * Passing the reports to dangerbot * removed jasmine tasks from Rakefile and other modifications * Modified the Dangerfile * Modified the travis.yml * Changed the Dangerfile * Shortened test for js failure * Some mistake while updation * Some changes in .travis.yml * Added junit-danger to Gemfile * Modified the Dangerfile * modification in Dangerfile * Modified Dangerfile * Modified the Dangerfile * Written only junit.failures * Reverted the changes required for Dangerbot reporting

ghost assigned Souravirus Jul 6, 2018

ghost added the in progress label Jul 6, 2018

Souravirus commented Jul 8, 2018

View reviewed changes

Souravirus commented Jul 9, 2018

View reviewed changes

Souravirus mentioned this pull request Jul 9, 2018

Community Check-in #8 Summer Of Code Week 9 #3010

Closed

Souravirus force-pushed the mocha branch 2 times, most recently from 6391c8d to 2747ff9 Compare July 10, 2018 16:00

Souravirus closed this Jul 10, 2018

ghost removed the in progress label Jul 10, 2018

Souravirus reopened this Jul 10, 2018

ghost added the in progress label Jul 10, 2018

Souravirus requested review from jywarren and a team July 10, 2018 18:35

Souravirus added ready review-me and removed in progress labels Jul 11, 2018

Souravirus added 12 commits July 16, 2018 16:39

Modified the Dangerfile

129eaaa

Modified the travis.yml

667d78a

Changed the Dangerfile

c1efddc

Shortened test for js failure

6935388

Some mistake while updation

b2342bd

Some changes in .travis.yml

0163625

Added junit-danger to Gemfile

a12226b

Modified the Dangerfile

a0226f1

modification in Dangerfile

a1aca65

Modified Dangerfile

d1ccec6

Modified the Dangerfile

9a93e4e

Written only junit.failures

20da9c0

Souravirus force-pushed the mocha branch from 5e955c8 to 20da9c0 Compare July 16, 2018 11:17

jywarren reviewed Jul 17, 2018

View reviewed changes

Souravirus mentioned this pull request Jul 20, 2018

Community Check-in #9 Summer Of Code Week 10 #3078

Closed

Reverted the changes required for Dangerbot reporting

5593eff

jywarren merged commit 1d6f21e into publiclab:master Jul 20, 2018

ghost removed the ready label Jul 20, 2018

Souravirus removed the review-me label Jul 20, 2018

Souravirus deleted the mocha branch July 20, 2018 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing jasmine tests to teaspoon-mocha #2997

Changing jasmine tests to teaspoon-mocha #2997

Souravirus commented Jul 6, 2018 •

edited

Loading

plotsbot commented Jul 6, 2018 •

edited

Loading

Souravirus Jul 8, 2018 •

edited

Loading

Souravirus Jul 8, 2018

Souravirus Jul 9, 2018

jywarren commented Jul 9, 2018 via email

Souravirus commented Jul 9, 2018

Souravirus commented Jul 10, 2018

Souravirus commented Jul 10, 2018

Souravirus commented Jul 10, 2018

Souravirus commented Jul 10, 2018

jywarren commented Jul 11, 2018

Souravirus commented Jul 11, 2018 •

edited

Loading

Souravirus commented Jul 11, 2018

jywarren commented Jul 11, 2018 via email

Souravirus commented Jul 11, 2018

Souravirus commented Jul 11, 2018

jywarren Jul 17, 2018

jywarren Jul 17, 2018

Souravirus Jul 18, 2018

jywarren commented Jul 17, 2018

jywarren commented Jul 17, 2018

Souravirus commented Jul 18, 2018

jywarren commented Jul 18, 2018 via email

Souravirus commented Jul 20, 2018

jywarren commented Jul 20, 2018

Souravirus commented Jul 20, 2018

jywarren commented Jul 20, 2018

		@@ -27,8 +27,12 @@ end

		message "Pull Request is marked as Work in Progress" if github.pr_title.include? "[WIP]"

		junit.parse "output2.xml"

Changing jasmine tests to teaspoon-mocha #2997

Changing jasmine tests to teaspoon-mocha #2997

Conversation

Souravirus commented Jul 6, 2018 • edited Loading

plotsbot commented Jul 6, 2018 • edited Loading

Souravirus Jul 8, 2018 • edited Loading

Choose a reason for hiding this comment

Souravirus Jul 8, 2018

Choose a reason for hiding this comment

Souravirus Jul 9, 2018

Choose a reason for hiding this comment

jywarren commented Jul 9, 2018 via email

Souravirus commented Jul 9, 2018

Souravirus commented Jul 10, 2018

Souravirus commented Jul 10, 2018

Souravirus commented Jul 10, 2018

Souravirus commented Jul 10, 2018

jywarren commented Jul 11, 2018

Souravirus commented Jul 11, 2018 • edited Loading

Souravirus commented Jul 11, 2018

jywarren commented Jul 11, 2018 via email

Souravirus commented Jul 11, 2018

Souravirus commented Jul 11, 2018

jywarren Jul 17, 2018

Choose a reason for hiding this comment

jywarren Jul 17, 2018

Choose a reason for hiding this comment

Souravirus Jul 18, 2018

Choose a reason for hiding this comment

jywarren commented Jul 17, 2018

jywarren commented Jul 17, 2018

Souravirus commented Jul 18, 2018

jywarren commented Jul 18, 2018 via email

Souravirus commented Jul 20, 2018

jywarren commented Jul 20, 2018

Souravirus commented Jul 20, 2018

jywarren commented Jul 20, 2018

Souravirus commented Jul 6, 2018 •

edited

Loading

plotsbot commented Jul 6, 2018 •

edited

Loading

Souravirus Jul 8, 2018 •

edited

Loading

Souravirus commented Jul 11, 2018 •

edited

Loading