Debian stretch (fixes #2811) #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I only checked tests pass, should deploy to |
Generated by 🚫 Danger |
|
Let's push to unstable to see first!
…On Wed, Jun 20, 2018, 4:14 AM plotsbot ***@***.***> wrote:
2 Messages
📖 @icarito <https://github.com/icarito> Thank you for your pull request!
I’m here to help with some tips and recommendations. Please take a look at
the list provided and help us review and accept your contribution! And *don’t
be discouraged if you see errors* – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review
and accept your suggested changes by going through the steps one by one. If
it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.
Generated by 🚫 Danger <https://danger.systems/>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2865 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJzm6ChLm7fJXjdYLkOHI7ln5NVgNks5t-gRcgaJpZM4Uuyzt>
.
|
|
pushed! |
|
It worked fine! https://unstable.publiclab.org/dashboard Shall we merge and go to stable? |
|
wait i'm not sure that's correct... have to check, hang on |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Switch base operating system image to Debian 9 (Stretch). * Change dependency names * Omit npm dependency for now * Install NPM just like https://github.com/Starefossen/docker-ruby-node/ * Add gpg key and define node version * Simplify use Stretch backports * Use backported nodejs. * Confirm apt installation * Install by setup script from nodejs.org * Install nodejs package * Don't use sudo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!