Google icon added to signup view #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
SidharthBansal
changed the title
Generated by 🚫 Danger |
grvsachdeva
approved these changes
Jun 19, 2018
|
Just wondering, how it will look after centering the block? 😅 |
|
We will also have 3 more icons for other 3 providers. Once, we are done with all 4 provider I will centre it. I know left justified looks a little bit odd. |
|
Awesome!!! |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2852
@jywarren I am trying to make other things as modular as I can. You can approve these views if they seem good to you else suggest changes. You can merge these views once the functionality of #2771 is checked by Soc people. Till then they will be kept under approved.