Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting a note as a Draft #2744

Merged
merged 9 commits into from
May 25, 2018
Merged

Conversation

grvsachdeva
Copy link
Member

@grvsachdeva grvsachdeva commented May 24, 2018

Solves #2667 4th, 6th and 7th part

Hi @jywarren, committing here until unstable is ready.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

namangupta01 and others added 7 commits May 10, 2018 15:43
* added an upgrade alert tag

* Additional questions page tweak (publiclab#2721)

* added the tag to determine which upgrade is listed on the website

* changed regex back

* added an upgrade alert tag

* added the tag to determine which upgrade is listed on the website

* changed regex back

* added upgrade after pull and rebase master
Updates the readme to change the installation instructions, fixes publiclab#2729
* draft display on dashboard

* moderator file view permitted

* checking

* fix

* test fix
@grvsachdeva grvsachdeva changed the title Submitting a note as a Draft [Don't Merge ] Submitting a note as a Draft May 24, 2018
@grvsachdeva
Copy link
Member Author

Build Failed with error
check_fail

@PublicLabBot
Copy link

2 Messages
📖 @Gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@grvsachdeva grvsachdeva changed the title [Don't Merge ] Submitting a note as a Draft Submitting a note as a Draft May 25, 2018
@grvsachdeva grvsachdeva merged commit df570b7 into publiclab:unstable May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants