-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add like feature for comments #2591
Conversation
Ooh, this is really nice. Almost ready to go, no? I see a test getting written -- i like this a lot! And i see you left the |
Hi, sorry for the late reply--had an exam today. There are some changes to be made in tests, will ping once completed |
0fe0d0e
to
07ff585
Compare
@jywarren made certain test related changes. I guess, it is good to be merged now. |
Don't know why the tests are failing. If you could have a look? |
Try rebasing over latest master; we just merged some fixes!
…On Fri, May 25, 2018, 3:54 PM Vidit ***@***.***> wrote:
Don't know why the tests are failing. If you could have a look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2591 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ8UG1VntHKZQ05yZhmQJ4co6WOzpks5t2GFogaJpZM4TK8ol>
.
|
ee1da62
to
82e3768
Compare
Generated by 🚫 Danger |
Thanks a ton!! So can we merge this if this looks good to you? |
Fantastic! Do you think we should think about refactoring the current Node like system? Don't have to think about this just yet. Maybe more pressing would be tests for the comment like system. Unit tests -- do you think you could add a few? Thanks!! |
* add like feature for comments * code climate fixes * changes in tests * changes in schema.rb.example * changes in schema.rb.example
closes #2498
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!