Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace blog link with stories from Read Stories button #2467

Closed
wants to merge 1 commit into from

Conversation

yashbth
Copy link
Contributor

@yashbth yashbth commented Mar 9, 2018

fixes issue #2454

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
PR body includes fixes #0000-style reference to original issue #
ask @publiclab/reviewers for help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@grvsachdeva grvsachdeva closed this Mar 9, 2018
@grvsachdeva grvsachdeva reopened this Mar 9, 2018
@PublicLabBot
Copy link

1 Message
📖 @yashbth Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@yashbth
Copy link
Contributor Author

yashbth commented Mar 12, 2018

@Gauravano all checks have passed, can it be merged now?

@grvsachdeva
Copy link
Member

hi @yashbth , I have just seen that PR for the same issue is open at #2457 and @jywarren has left some comments there, so I guess there is some change in plan.

@yashbth yashbth closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants