Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made RSS feed a valid one + functional test for it #2024

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Made RSS feed a valid one + functional test for it #2024

merged 3 commits into from
Jan 17, 2018

Conversation

sagarpreet-chadha
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha commented Jan 16, 2018 •
edited
Loading

Some changes to #1958 .

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

Thanks!

@jywarren
Copy link
Member

Hmm, not sure why, but looks like an error. I just tweaked the spacing a bit, so it wasn't my change... great changes btw!

@sagarpreet-chadha
Copy link
Contributor Author

@jywarren ,thank you , also i was thinking about what would happen if the body/description length is greater than the tweet character limit ? What do you think ?

@jywarren
Copy link
Member

I think it'll auto-truncate, but tweets are also longer now :-)

Do you know why it's stalling?

@PublicLabBot
Copy link

2 Messages
📖 @sagarpreet-chadha Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Awesome!

@jywarren jywarren merged commit e606fc2 into publiclab:master Jan 17, 2018
@jywarren jywarren mentioned this pull request Jan 17, 2018
Closed
@sagarpreet-chadha sagarpreet-chadha deleted the patch-15 branch March 19, 2018 06:42
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@sagarpreet-chadha @jywarren
Made RSS feed a valid one + functional test for it (publiclab#2024)
6dd6773 
* Made rss feed builder a valid one

* Added tests for RSS Builder

* Update notes_controller_test.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagarpreet-chadha @jywarren @PublicLabBot