Fix Error reporting and parsing (fixes #1852)

[ryzokuken]

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

• all tests pass -- rake test:all
• code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
• pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

[PublicLabBot]

	2 Messages
📖	@ryzokuken Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[ryzokuken]

@jywarren YAY! Let me know when you're okay with this one, and I'll remove the error.

[jywarren]

Looks perfect, fantastic fix thank you @ryzokuken!

…

On Dec 10, 2017 3:00 AM, "Ujjwal Sharma" ***@***.***> wrote: @jywarren <https://github.com/jywarren> YAY! Let me know when you're okay with this one, and I'll remove the error. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1857 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJxYwtpJGcpZDuz2X2NWSuqOfxI9Vks5s-4-GgaJpZM4Q8aMF> .

[ryzokuken]

@jywarren so, here it is. Feel free to merge this.

[ryzokuken]

@jywarren this happened:

$ touch ./test/reports/TEST_.xml

touch: cannot touch ‘./test/reports/TEST_.xml’: Permission denied

The command "touch ./test/reports/TEST_.xml" exited with 1.

strange. Why are there permission issues to begin with? There weren't any earlier and we didn't change anything related to the directory permissions, did we?

Also, generally, I had no idea why were doing all the stuff in

plots2/.travis.yml

Lines 21 to 26 in 16e7279

	- docker-compose run -e CI=TRUE web bash -c "GENERATE_REPORT=true rake test:all"
	- mkdir -p ./test/reports
	- touch ./test/reports/TEST_.xml
	- echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml
	- tail -n +2 -q ./test/reports/TEST*.xml >> output.xml
	- 'if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then danger --verbose; fi'

in the first place... Specifically the lines in

plots2/.travis.yml

Lines 22 to 24 in 16e7279

	- mkdir -p ./test/reports
	- touch ./test/reports/TEST_.xml
	- echo -e '<?xml version="1.0" encoding="UTF-8"?>' > output.xml

. We run the tests, generating reports on the way, join together all the reports in a single output.xml file and then run danger on the output.xml, parsing it and making a comment.

But why do we make an empty file in there? Why make the directory? Doesn't the directory already exist? What purpose does the empty file serve?

[jywarren]

Hi, @ryzokuken -- i inserted those lines because the Junit generation wasn't working and we saw a test error due to that directory not working. I think we can remove them and it should resolve now that you've gotten Junit working again.

[jywarren]

I removed them -- let's see!

[ryzokuken]

@jywarren sure, gimme a second.

[ryzokuken]

Oh, wait. You already did. 😛

Thanks

[ryzokuken]

@jywarren It worked! YAY!

[jywarren]

🥂 👍 💯

[ryzokuken]

@jywarren what next? Anything you specifically wanted me to work on?