Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag model methods find_popular_notes and find_top_nodes_by_type #1676 #1772

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Fix tag model methods find_popular_notes and find_top_nodes_by_type #1676 #1772

merged 1 commit into from
Nov 14, 2017

Conversation

tyricec
Copy link
Contributor

@tyricec tyricec commented Nov 13, 2017

Fixes #1676

@PublicLabBot
Copy link

1 Message
📖 @tyricec Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

This is amazing! Fantastic tests as well. Thank you -- merging now. If you're looking for a new challenge, please take a look at our help-wanted list: https://github.com/publiclab/plots2/labels/help-wanted

Thanks again!

@jywarren jywarren merged commit 077d69f into publiclab:master Nov 14, 2017
@tyricec
Copy link
Contributor Author

tyricec commented Nov 14, 2017

Thanks. Will do :)

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@jywarren
fix: Change include to includes in tag model (publiclab#1772)
4458a73 
Fixes publiclab#1676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyricec @PublicLabBot @jywarren