Added publiclab editor,fixes #904 #1177
Conversation
|
@jywarren Do I need to integrate the editor only in the "Share your work" textarea? |
|
Hmm, can you elaborate on your last question? Also, does this seem to work on your local setup, and could you upload a screenshot so I could take a look? Thanks! |
|
@jywarren I meant, where should I integrate the publiclab editor? In the "Share your work" text area? |
|
Ah, i see -- and apologies for the slow response, we've had some outages and also Github was even briefly down (!). Actually the code from "rich.html.erb" can replace the entire |
|
@jywarren There is no |
|
Oh, i'm so sorry I missed this and didn't respond earlier! I've been a bit extra busy this past week. Looking now. |
| </div> | ||
|
|
||
| </div> | ||
| <%= javascript_include_tag "post" %> |
There was a problem hiding this comment.
See how here, the new "rich" template ends and the older editor template begins? You actually only need one of the two -- that's why you're seeing the old form sort of overlaid on the new one. You should be able to remove everything below this line, but transfer some of the special question-related features from the old template to the new. I'll mark the ones I see.
| url = { :controller => "notes", :action => "create", :id => params[:id] } | ||
| end | ||
| %> | ||
| <%= form_for @node, :as => :drupal_node, :url => url do |f| %> |
There was a problem hiding this comment.
Here's where the second form is generated. But actually upon reading through it, I don't think there's anything in particular you need to save from this older form. I think you can just delete it and get this template (and its corresponding controller) to match rich.html.erb as closely as you can.
Then we can take the next steps on the design and getting it to look like the mockup.
|
Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks! |
|
@jywarren Hi, I'm having exams right now. I will continue working on it in a couple of days. |
|
Good luck! |
|
Awesome, thanks!
…On Feb 22, 2017 11:23 AM, "Swapnil Gupta" ***@***.***> wrote:
Hey @jywarren <https://github.com/jywarren> My exams are over. I will
continue working on this issue. I have created another PR #1286
<#1286>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1177 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5FsH5gPsKzahTh5uD4Yjgjp6QHoks5rfItBgaJpZM4LemUM>
.
|
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake test:allschema.rb.examplehas been updated if any database migrations were addedPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!