Modified functional scope to block scope in javascript

[Josephsanya]

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

[gitpod-io]

[github-actions]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8893815460/artifacts/406821161

[codecov]

Codecov Report

Merging #11526 (11c1049) into main (3496818) will increase coverage by 32.94%.
The diff coverage is n/a.

❗ Current head 11c1049 differs from pull request most recent head 78a8076. Consider uploading reports for the commit 78a8076 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #11526       +/-   ##
===========================================
+ Coverage   50.26%   83.21%   +32.94%     
===========================================
  Files          93       93               
  Lines        5946     5772      -174     
===========================================
+ Hits         2989     4803     +1814     
+ Misses       2957      969     -1988     

Impacted Files	Coverage Δ
app/models/image.rb	82.05% <0.00%> (+2.56%)	⬆️
app/models/spamaway.rb	97.43% <0.00%> (+2.56%)	⬆️
app/models/node_tag.rb	100.00% <0.00%> (+3.70%)	⬆️
app/helpers/comment_helper.rb	100.00% <0.00%> (+3.84%)	⬆️
app/models/concerns/statistics.rb	100.00% <0.00%> (+8.19%)	⬆️
app/controllers/images_controller.rb	72.50% <0.00%> (+10.00%)	⬆️
app/services/search_criteria.rb	95.74% <0.00%> (+12.76%)	⬆️
app/models/user_tag.rb	100.00% <0.00%> (+13.04%)	⬆️
app/helpers/application_helper.rb	88.65% <0.00%> (+13.40%)	⬆️
app/controllers/home_controller.rb	95.58% <0.00%> (+14.70%)	⬆️
... and 42 more

[TildaDares]

Hi @Josephsanya, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

[Josephsanya]

Hello @TildaDares , I didn't fix it from an issue. It was just some improvements I made while going through the code.

[TildaDares]

Hi @Josephsanya, we prefer to create issues first so that other contributors don't try to solve the same issues. It also gives the maintainers time to review the issue before you open a PR for it.

[TildaDares]

For example, it looks like @ijayhub has opened a PR for one of the files you've added in this PR #11524.

[codeclimate]

Code Climate has analyzed commit 78a8076 and detected 0 issues on this pull request.

View more on Code Climate.