Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature inline grid.js #11511

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,12 +211,11 @@ To report security vulnerabilities or for questions about security, please conta
Help improve Public Lab software!

* Join the plots-dev@googlegroups.com discussion list to get involved
* Most of the contributors network on our [gitter chat](https://gitter.im/publiclab/publiclab)
* Look for open issues at https://github.com/publiclab/plots2/labels/help-wanted
* We're specifically asking for help with issues labelled with [help-wanted](https://github.com/publiclab/plots2/labels/help-wanted) tag
* Find lots of info on contributing at http://publiclab.org/wiki/developers
* Review specific contributor guidelines at http://publiclab.org/wiki/contributing-to-public-lab-software
* Some devs hang out in http://publiclab.org/chat (irc webchat)
* Join our gitter chat at https://gitter.im/publiclab/publiclab
* Review specific contributor guidelines at http://publiclab.org/wiki/contributing-to-public-lab-software
* Try out some supportive tasks https://github.com/publiclab/plots2/wiki/Supportive-Tasks
* Get involved with our weekly community check-ins. For guidelines: [https://github.com/publiclab/plots2/tree/master/doc/CHECKINS.md
](https://github.com/publiclab/plots2/tree/master/doc/CHECKINS.md)
Expand Down
2 changes: 1 addition & 1 deletion app/views/dashboard/_node_meta.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

<div class="card-meta-links">
<a href="<%= node.path %>#comments"><i class="fa fa-comment-o"></i> <%= node.comments_viewable_by(current_user).length %></a>
| <a href="/n/<%= node.id %>"><i class="fa fa-link"></i></a>
| <a aria-label="Link to note" href="/n/<%= node.id %>"><i class="fa fa-link"></i></a>
| <span><i class="fa fa-eye"></i> <%= number_with_delimiter(node.views) %></span>
| <span><i style="<% if node.likes > 0 %>color:#db4;<% end %>" class="fa fa-star-o"></i> <%= node.likes %></span>
<% if params[:mod] %>| <a href="#"><i class="fa fa-ban"></i></a><% end %>
Expand Down
76 changes: 0 additions & 76 deletions doc/GCI_MENTOR_GUIDELINES.md

This file was deleted.

42 changes: 18 additions & 24 deletions spec/javascripts/inline_grids_spec.js
Original file line number Diff line number Diff line change
@@ -1,38 +1,32 @@
/* eslint-disable no-empty-label */

var editor;
let editor;

fixture.preload("inline_grid.html");

describe("Inline grids", function() {

beforeEach(function() {

this.fixtures = fixture.load("inline_grid.html");

describe("Inline grids", function () {
beforeEach(function () {
this.fixtures = fixture.load("inline_grid.html");
});

it("sends a like request when like button is clicked", function () {
expect($($(".notes-grid tr")[1]).find("td:first a").html()).to.eql(
"First post"
);

it("sends a like request when like button is clicked", function() {


expect($($('.notes-grid tr')[1]).find('td:first a').html()).to.eql('First post');

$('table:first th:first a').trigger('click');
$("table:first th:first a").trigger("click");

setTimeout(0, function() {

expect($($('.notes-grid tr')[1]).find('td:first a').html()).to.eql('Third post');

setTimeout(0, function() {

$('table:first th:first a').trigger('click');
expect($($('.notes-grid tr')[1]).find('td:first a').html()).to.eql('First post');
setTimeout(0, function () {
expect($($(".notes-grid tr")[1]).find("td:first a").html()).to.eql(
"Third post"
);

setTimeout(0, function () {
$("table:first th:first a").trigger("click");
expect($($(".notes-grid tr")[1]).find("td:first a").html()).to.eql(
"First post"
);
});

});

});

});