Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user_notification_channel.rb #11421

Closed
wants to merge 1 commit into from
Closed

Update user_notification_channel.rb #11421

wants to merge 1 commit into from

Conversation

giftade
Copy link
Contributor

@giftade giftade commented Sep 15, 2022

fixed the if/else condtion

Fixes #11418

@gitpod-io
Copy link

gitpod-io bot commented Sep 15, 2022

@codeclimate
Copy link

codeclimate bot commented Sep 15, 2022

Code Climate has analyzed commit e224c86 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 4

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8303961699/artifacts/364391524

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #11421 (e224c86) into main (3a9b53f) will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11421      +/-   ##
==========================================
+ Coverage   82.41%   82.53%   +0.11%     
==========================================
  Files          96       96              
  Lines        5948     5948              
==========================================
+ Hits         4902     4909       +7     
+ Misses       1046     1039       -7     
Impacted Files Coverage Δ
app/channels/user_notification_channel.rb 83.33% <66.66%> (ø)
app/api/srch/search.rb 70.51% <0.00%> (+3.84%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@giftade giftade closed this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rubocop fix: Invert if/else condition notification_channel
1 participant