-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update on 404.html #11352
Update on 404.html #11352
Conversation
Deleted line 68 to 76 Added Open Chatroom link
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit a860f7f and detected 0 issues on this pull request. View more on Code Climate. |
Hello, this is my first time contributing to this project and I have one of my checks on this pull request failed. Can anyone help me and provide a guidance on how to resolve the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job @zexinbeh. Thank you!!
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Codecov Report
@@ Coverage Diff @@
## main #11352 +/- ##
==========================================
+ Coverage 82.33% 82.45% +0.11%
==========================================
Files 98 98
Lines 5996 5996
==========================================
+ Hits 4937 4944 +7
+ Misses 1059 1052 -7
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Congratulations on merging your PR @zexinbeh 🎉 |
Deleted line 68 to 76
Added new line of code at line 68 for 'Open Chatroom' link
Fixes #11340
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
[✔️]PR is descriptively titled 📑 and links the original issue above 🔗
[ ] Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
[✔️] Code is in uniquely-named feature branch and has no merge conflicts 📁
[ ] Screenshots/GIFs are attached 📎 in case of UI updation
[ ] Ask @publiclab/reviewers for help, in a comment below