Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Comment Form While Guest Browsing #11072

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

noi5e
Copy link
Contributor

@noi5e noi5e commented Apr 18, 2022

This PR makes changes in the React rewrite of the commenting system.

It disables the login form at the bottom of notes while guest browsing (user isn't logged in):

Before the change:
Screen Shot 2022-04-18 at 1 48 07 PM

After the change:
Screen Shot 2022-04-18 at 1 46 49 PM


(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issues #9069 and #9365 for more context)

@gitpod-io
Copy link

gitpod-io bot commented Apr 18, 2022

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6164536886/artifacts/215984174

@codeclimate
Copy link

codeclimate bot commented Apr 18, 2022

Code Climate has analyzed commit b9a7d08 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6165593339/artifacts/216058526

@noi5e noi5e closed this Apr 19, 2022
@noi5e noi5e reopened this Apr 19, 2022
@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6166215619/artifacts/216097851

@jywarren jywarren merged commit b9d5575 into publiclab:main Apr 19, 2022
@jywarren
Copy link
Member

Excellent, thank you @noi5e !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants