Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Suggest a new title" feature to make friendly suggestions of more descriptive titles #919

Closed
jywarren opened this issue Oct 24, 2016 · 8 comments · Fixed by #2000
Closed

"Suggest a new title" feature to make friendly suggestions of more descriptive titles #919

jywarren opened this issue Oct 24, 2016 · 8 comments · Fixed by #2000
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby

Comments

@jywarren
Copy link
Member

This would need some UI design work, but the idea is that it'd be a comment which could actually have a button on it that says something like:

Jeff is suggesting an alternative title, "How to fix a Time Machine Kit". To accept this as a new title to your post, click here.

Then that button would directly replace your title. Curious what people think of this idea -- it'd likely need both a new controller action in the notes controller, and some well-thought-through UI design leading into the comment display template: https://github.com/publiclab/plots2/blob/master/app/views/comments/_comments.html.erb
@jywarren jywarren added enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby design issue requires more design work and discussion (i.e. mockups and sketches) labels Oct 24, 2016
@ebarry
Copy link
Member

ebarry commented Oct 25, 2016

Seems like I see this idea from multiple perspectives, one of them is that this is essentially a type of in-line commenting that helps us help each other granularly improve our communication.

At first though, reading this does kind of rub me the wrong way because i do love personal / idiosyncratic expression ... but i then i kind of come around to this idea for helping each other clarify our phrasing. I think we're here using the publiclab.org platform and sister platforms to collaborate not only on developing methods but also to collaborate on communicating so more people can get involved.

@ebarry
Copy link
Member

ebarry commented Oct 25, 2016

Hi @pdhixenbaugh here's the issue about helping to improve titles that we mentioned on the open call earlier today!

@ViditChitkara
Copy link
Member

@jywarren, @ebarry I want to work on it if it is available!

@ViditChitkara
Copy link
Member

@jywarren I have an idea about this feature.
Just like including inline power tags in the body we could use another syntax For eg:- {Changed title}. We could then use regex to detect this and embed a partial just like question grids, activity grids, etc.
Your thoughts??

@ViditChitkara
Copy link
Member

Submitting a pr for this!!

ViditChitkara added a commit to ViditChitkara/plots2 that referenced this issue Jan 13, 2018
@ViditChitkara
added "Suggest new title" feature
2d4f004 
closes publiclab#919
@ViditChitkara ViditChitkara mentioned this issue Jan 13, 2018
Merged
3 tasks
@jywarren
Copy link
Member Author

jywarren commented Jan 14, 2018 via email

@ViditChitkara
Copy link
Member

Yes, this would be in the comment. Currently I have used ( {New Title} ) curly braces instead which could be easily changed according to the design we finalise.

ViditChitkara added a commit to ViditChitkara/plots2 that referenced this issue Jan 14, 2018
@ViditChitkara
added "Suggest new title" feature
142d6d2 
closes publiclab#919
ViditChitkara added a commit to ViditChitkara/plots2 that referenced this issue Jan 16, 2018
@ViditChitkara
added "Suggest new title" feature
eb47ecc 
closes publiclab#919
ViditChitkara added a commit to ViditChitkara/plots2 that referenced this issue Jan 17, 2018
@ViditChitkara
added "Suggest new title" feature
9a006ac 
closes publiclab#919
jywarren pushed a commit that referenced this issue Jan 25, 2018
@ViditChitkara @jywarren
added "Suggest new title" feature (#2000)
71c01bd 
* added "Suggest new title" feature

closes #919

* formatted routes

* few changes for simplification

* authorisation check to request_title_change method

* changes for test faliures

* minor changes and enhancements

* minor changes

* changed inline syntax for title suggestion

* written tests

* added more tests
@jywarren
Copy link
Member Author

@pdhixenbaugh @ebarry this was just completed! :-) 🎈

This was referenced Jan 26, 2018
Merged
Closed
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this issue May 5, 2019
@ViditChitkara @jywarren
added "Suggest new title" feature (publiclab#2000)
b920b14 
* added "Suggest new title" feature

closes publiclab#919

* formatted routes

* few changes for simplification

* authorisation check to request_title_change method

* changes for test faliures

* minor changes and enhancements

* minor changes

* changed inline syntax for title suggestion

* written tests

* added more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added "Suggest new title" feature ViditChitkara/plots2
3 participants
@jywarren @ebarry @ViditChitkara