-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Progress Bars Don't Show for Edit Comment CLICK-to-Upload Image #9018
Labels
bug
the issue is regarding one of our programs which faces problems when a certain task is executed
JavaScript
outreachy
Milestone
Comments
noi5e
added a commit
to noi5e/plots2
that referenced
this issue
Jan 16, 2021
noi5e
added a commit
to noi5e/plots2
that referenced
this issue
Jan 17, 2021
noi5e
added a commit
to noi5e/plots2
that referenced
this issue
Jan 17, 2021
noi5e
added a commit
to noi5e/plots2
that referenced
this issue
Jan 17, 2021
noi5e
added a commit
to noi5e/plots2
that referenced
this issue
Jan 17, 2021
noi5e
added a commit
to noi5e/plots2
that referenced
this issue
Jan 17, 2021
noi5e
added a commit
to noi5e/plots2
that referenced
this issue
Jan 17, 2021
noi5e
added a commit
to noi5e/plots2
that referenced
this issue
Jan 17, 2021
jywarren
pushed a commit
that referenced
this issue
Jan 18, 2021
…9019) * add tests for image upload progress bars #9018 * fix image upload hover & progress bar issues #9018 * change ID references to class references #9018 * fix style for edit comment forms on questions #9018 * add classes to image upload progress bars #9018 * add classes; remove non-unique IDs #9018 * tweak image upload progress bar tests #9018 * forgot to remove screenshot #9018
manchere
pushed a commit
to manchere/plots2
that referenced
this issue
Feb 13, 2021
…ubliclab#9019) * add tests for image upload progress bars publiclab#9018 * fix image upload hover & progress bar issues publiclab#9018 * change ID references to class references publiclab#9018 * fix style for edit comment forms on questions publiclab#9018 * add classes to image upload progress bars publiclab#9018 * add classes; remove non-unique IDs publiclab#9018 * tweak image upload progress bar tests publiclab#9018 * forgot to remove screenshot publiclab#9018
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this issue
Mar 2, 2021
…ubliclab#9019) * add tests for image upload progress bars publiclab#9018 * fix image upload hover & progress bar issues publiclab#9018 * change ID references to class references publiclab#9018 * fix style for edit comment forms on questions publiclab#9018 * add classes to image upload progress bars publiclab#9018 * add classes; remove non-unique IDs publiclab#9018 * tweak image upload progress bar tests publiclab#9018 * forgot to remove screenshot publiclab#9018
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this issue
Oct 16, 2021
…ubliclab#9019) * add tests for image upload progress bars publiclab#9018 * fix image upload hover & progress bar issues publiclab#9018 * change ID references to class references publiclab#9018 * fix style for edit comment forms on questions publiclab#9018 * add classes to image upload progress bars publiclab#9018 * add classes; remove non-unique IDs publiclab#9018 * tweak image upload progress bar tests publiclab#9018 * forgot to remove screenshot publiclab#9018
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this issue
Dec 28, 2021
…ubliclab#9019) * add tests for image upload progress bars publiclab#9018 * fix image upload hover & progress bar issues publiclab#9018 * change ID references to class references publiclab#9018 * fix style for edit comment forms on questions publiclab#9018 * add classes to image upload progress bars publiclab#9018 * add classes; remove non-unique IDs publiclab#9018 * tweak image upload progress bar tests publiclab#9018 * forgot to remove screenshot publiclab#9018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
the issue is regarding one of our programs which faces problems when a certain task is executed
JavaScript
outreachy
Steps to Reproduce:
Edit.Comment.Image.Upload.Progress.Bars.Bug.Before.Fix.mov
This bug occurs because the toolbar button in edit comment forms call on a
fileupload
method indragdrop.js
. The CSS selectors in this method refer to elements that exist in reply and main comment forms, but that DON'T exist in edit comment forms:plots2/app/assets/javascripts/dragdrop.js
Lines 78 to 82 in a3c8796
Here's how they are in edit comment forms:
plots2/app/views/comments/_edit.html.erb
Lines 17 to 28 in a3c8796
As opposed to reply and main comment forms:
plots2/app/views/comments/_form.html.erb
Lines 64 to 75 in a3c8796
Going to take care of this bug in stages:
.progress
instead of#create_upload
.I think this bugfix will pave the way for combining the scripts for edit comment forms with scripts for reply/main comment forms... They're so similar, it would really be helpful if they were just consolidated.
(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)
The text was updated successfully, but these errors were encountered: