-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong text input gets selected while using toolbar on comments #8478
Comments
Correct! |
Hi @Sagarpreet . Outreachy applicant here. Can I take a look at this? |
Hey @nibble0101 , yes we would like your help 👍 |
Hi @sagarpreet-chadha - just noting that the "spin out new library" would happen /after/ most of the fixes and refinements in the Comment project - it'll be a stretch goal. Thanks! This is a great catch @urvashigupta7 and I think we'll have to do a couple things. We should identify all the various types of comment boxes -- i made a list below -- and ensure that a proper unique CSS
This is a major part of the Comment project for Outreachy! |
Starting to work on this one! Just made a PR to add unique IDs to the toolbar buttons. After that, I think it will be a very similar fix to the image upload cross-wiring issues (linked above in this issue) |
* add logic for editor/toolbar partial publiclab#8478 * add unique toolbar button IDs publiclab#8478 * remove trailing whitespaces
* add rich-text tests publiclab#8478 * fix indentation publiclab#8478 * delete onclick for rich-text buttons; add data-action attribute publiclab#8478 * add click handler for rich-text buttons publiclab#8478 * extract code to editorHelper for DRY publiclab#8478 * require editorHelper.js publiclab#8478 * change == to === publiclab#8478
* add logic for editor/toolbar partial publiclab#8478 * add unique toolbar button IDs publiclab#8478 * remove trailing whitespaces
* add rich-text tests publiclab#8478 * fix indentation publiclab#8478 * delete onclick for rich-text buttons; add data-action attribute publiclab#8478 * add click handler for rich-text buttons publiclab#8478 * extract code to editorHelper for DRY publiclab#8478 * require editorHelper.js publiclab#8478 * change == to === publiclab#8478
* add logic for editor/toolbar partial publiclab#8478 * add unique toolbar button IDs publiclab#8478 * remove trailing whitespaces
* add rich-text tests publiclab#8478 * fix indentation publiclab#8478 * delete onclick for rich-text buttons; add data-action attribute publiclab#8478 * add click handler for rich-text buttons publiclab#8478 * extract code to editorHelper for DRY publiclab#8478 * require editorHelper.js publiclab#8478 * change == to === publiclab#8478
* add logic for editor/toolbar partial publiclab#8478 * add unique toolbar button IDs publiclab#8478 * remove trailing whitespaces
* add rich-text tests publiclab#8478 * fix indentation publiclab#8478 * delete onclick for rich-text buttons; add data-action attribute publiclab#8478 * add click handler for rich-text buttons publiclab#8478 * extract code to editorHelper for DRY publiclab#8478 * require editorHelper.js publiclab#8478 * change == to === publiclab#8478
While trying to add new comment when any of the option is choosen from toolbar the changes are displayed in different text input.
where to look
https://publiclab.org/questions/Cogreg/09-20-2020/how-do-i-test-home-made-fertilizer
The text was updated successfully, but these errors were encountered: