Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong text input gets selected while using toolbar on comments #8478

Closed
urvashigupta7 opened this issue Oct 7, 2020 · 5 comments · Fixed by #9011
Closed

Wrong text input gets selected while using toolbar on comments #8478

urvashigupta7 opened this issue Oct 7, 2020 · 5 comments · Fixed by #9011
Assignees
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed

Comments

@urvashigupta7
Copy link
Contributor

While trying to add new comment when any of the option is choosen from toolbar the changes are displayed in different text input.

ezgif com-video-to-gif (6)

where to look

https://publiclab.org/questions/Cogreg/09-20-2020/how-do-i-test-home-made-fertilizer

@urvashigupta7 urvashigupta7 added the bug the issue is regarding one of our programs which faces problems when a certain task is executed label Oct 7, 2020
@Sagarpreet
Copy link
Contributor

Correct!
Always the first comment editor is changed. This is because if do not have any id associated to each comment editor.

@nibble0101
Copy link

Hi @Sagarpreet . Outreachy applicant here. Can I take a look at this?

@sagarpreet-chadha
Copy link
Contributor

Hey @nibble0101 , yes we would like your help 👍
So this is a little big issue, you may want to break this down 😄
Also let’s wait for @jywarren approval before we start because we might want to spin off a separate library for comment editor and solving here may not be useful now.

@jywarren
Copy link
Member

Hi @sagarpreet-chadha - just noting that the "spin out new library" would happen /after/ most of the fixes and refinements in the Comment project - it'll be a stretch goal. Thanks!

This is a great catch @urvashigupta7 and I think we'll have to do a couple things. We should identify all the various types of comment boxes -- i made a list below -- and ensure that a proper unique CSS id is assigned for all of them, in a standard way, and protect this with tests --

* comment
* reply to comment
* comment just posted (form inserted via AJAX)
* reply to comment just posted
* editing existing comments
* editing comments just posted
* editing comment replies
* editing comment replies just posted

This is a major part of the Comment project for Outreachy!

@noi5e
Copy link
Contributor

noi5e commented Jan 12, 2021

Starting to work on this one! Just made a PR to add unique IDs to the toolbar buttons. After that, I think it will be a very similar fix to the image upload cross-wiring issues (linked above in this issue)

jywarren pushed a commit that referenced this issue Jan 12, 2021
* add logic for editor/toolbar partial #8478

* add unique toolbar button IDs #8478

* remove trailing whitespaces
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 13, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 13, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 13, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
noi5e added a commit to noi5e/plots2 that referenced this issue Jan 14, 2021
cesswairimu pushed a commit that referenced this issue Jan 17, 2021
* add rich-text tests #8478

* fix indentation #8478

* delete onclick for rich-text buttons; add data-action attribute #8478

* add click handler for rich-text buttons #8478

* extract code to editorHelper for DRY #8478

* require editorHelper.js #8478

* change == to === #8478
manchere pushed a commit to manchere/plots2 that referenced this issue Feb 13, 2021
* add logic for editor/toolbar partial publiclab#8478

* add unique toolbar button IDs publiclab#8478

* remove trailing whitespaces
manchere pushed a commit to manchere/plots2 that referenced this issue Feb 13, 2021
* add rich-text tests publiclab#8478

* fix indentation publiclab#8478

* delete onclick for rich-text buttons; add data-action attribute publiclab#8478

* add click handler for rich-text buttons publiclab#8478

* extract code to editorHelper for DRY publiclab#8478

* require editorHelper.js publiclab#8478

* change == to === publiclab#8478
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this issue Mar 2, 2021
* add logic for editor/toolbar partial publiclab#8478

* add unique toolbar button IDs publiclab#8478

* remove trailing whitespaces
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this issue Mar 2, 2021
* add rich-text tests publiclab#8478

* fix indentation publiclab#8478

* delete onclick for rich-text buttons; add data-action attribute publiclab#8478

* add click handler for rich-text buttons publiclab#8478

* extract code to editorHelper for DRY publiclab#8478

* require editorHelper.js publiclab#8478

* change == to === publiclab#8478
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
* add logic for editor/toolbar partial publiclab#8478

* add unique toolbar button IDs publiclab#8478

* remove trailing whitespaces
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
* add rich-text tests publiclab#8478

* fix indentation publiclab#8478

* delete onclick for rich-text buttons; add data-action attribute publiclab#8478

* add click handler for rich-text buttons publiclab#8478

* extract code to editorHelper for DRY publiclab#8478

* require editorHelper.js publiclab#8478

* change == to === publiclab#8478
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
* add logic for editor/toolbar partial publiclab#8478

* add unique toolbar button IDs publiclab#8478

* remove trailing whitespaces
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
* add rich-text tests publiclab#8478

* fix indentation publiclab#8478

* delete onclick for rich-text buttons; add data-action attribute publiclab#8478

* add click handler for rich-text buttons publiclab#8478

* extract code to editorHelper for DRY publiclab#8478

* require editorHelper.js publiclab#8478

* change == to === publiclab#8478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed
Projects
None yet
6 participants