Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Link to) advanced search is wack! #800

Closed
ebarry opened this issue Sep 7, 2016 · 6 comments
Closed

(Link to) advanced search is wack! #800

ebarry opened this issue Sep 7, 2016 · 6 comments
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed high-priority

Comments

@ebarry
Copy link
Member

ebarry commented Sep 7, 2016

What happened just before the problem occurred

i searched for a term for which there were no results. (i recreated this error with a neutral term "noresults" (haha): https://publiclab.org/search/noresults

Screenshot:
screen shot 2016-09-07 at 5 22 42 pm

On that page of no results, i clicked on the link in "Try an advanced search" -- which went to a broken page of URL https://publiclab.org/searches/advanced/

screen shot 2016-09-07 at 5 19 35 pm

PublicLab.org username

liz

@jywarren
Copy link
Member

jywarren commented Sep 7, 2016

I believe this is pending @ujithaperera's work in #781, but there could also be a separate issue in @david-days API code? Would you two mind taking a look?

@jywarren jywarren added the bug the issue is regarding one of our programs which faces problems when a certain task is executed label Sep 7, 2016
@david-days
Copy link
Collaborator

I will take a look. I am betting on routes.rb, which was reworked a few
times over gsoc.

On Sep 7, 2016 5:56 PM, "Jeffrey Warren" notifications@github.com wrote:

I believe this is pending @ujithaperera https://github.com/ujithaperera's
work in #781 #781, but there
could also be a separate issue in @david-days
https://github.com/david-days API code? Would you two mind taking a
look?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#800 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOOfYLF6EyMMvjoFi9ilnc2BQqM25Ybfks5qnzLzgaJpZM4J3X4W
.

@ujithaperera
Copy link
Contributor

This can be fixed easily by adding correct link to the page. But I also found that several route duplications in the the file.

@jywarren
Copy link
Member

#810 was just merged in, and we'll be looking at advanced search functionality once it gets published on the site on Thursday; it may take some additional tweaks.

@jywarren jywarren changed the title Link to advanced search is wack! (Link to) advanced search is wack! Sep 21, 2016
@jywarren
Copy link
Member

This needs additional work for tests that return no results. I'll see what I can do!

@jywarren
Copy link
Member

jywarren commented Oct 5, 2016

I wasn't able to reproduce this on publiclab.org and think perhaps it's been fixed already!

@jywarren jywarren closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed high-priority
Projects
None yet
Development

No branches or pull requests

4 participants