Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate display of power tags from normal tags #775

Closed
jywarren opened this issue Sep 1, 2016 · 6 comments
Closed

Separate display of power tags from normal tags #775

jywarren opened this issue Sep 1, 2016 · 6 comments
Labels
fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute Ruby summer-of-code

Comments

@jywarren
Copy link
Member

jywarren commented Sep 1, 2016

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @jywarren to get it labelled.


Power tags (in key:value format) and regular tags are mixed in display:

https://publiclab.org/notes/liz/08-30-2016/check-out-these-activity-grids#tags

We should show the power tags separately, perhaps show them in purple or grey, and also link the words "Power tags" in the label to the above explanation of them.

This may also be where we could show an expanded interface for adding powertags, as in #496 -- and should in any case link to power tags documentation at https://publiclab.org/wiki/power-tags

Tags are displayed in this template: https://github.com/publiclab/plots2/blob/master/app/views/tag/_tagging.html.erb#L5

@node.community_tags, used there, is defined here -- it's just an alias to an ActiveRecord relation: https://github.com/publiclab/plots2/blob/master/app/models/drupal_node.rb#L436

We should use the more specific @node.power_tag_objects and @node.normal_tags to separate these out (see here for docs).

If we can think of a more compact way to display these, that'd be great, too!

@jywarren jywarren added this to the Activity grids milestone Sep 1, 2016
@jywarren jywarren added help wanted requires help by anyone willing to contribute Ruby labels Oct 13, 2016
@jywarren jywarren added the fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet label Oct 31, 2016
@jywarren
Copy link
Member Author

@ananyo2012 , perhaps this'd be a good GCI candidate?

@ananyo2012
Copy link
Member

Yes this involves work on CSS and designing as well. A good GCI candidate.

@gaeun
Copy link
Collaborator

gaeun commented Jan 5, 2017

I'd like to work on this issue please. :)

@ananyo2012
Copy link
Member

ananyo2012 commented Jan 5, 2017 via email

@gaeun
Copy link
Collaborator

gaeun commented Jan 9, 2017

@ananyo2012 @jywarren I think we can close this via #1174.

@ananyo2012
Copy link
Member

Ah thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute Ruby summer-of-code
Projects
None yet
Development

No branches or pull requests

3 participants