Dragging image into wiki pages is broken

[jywarren]

I'm having trouble dragging an image onto a wiki edit page; it returns an error on this line of dragdrop.js:

($D.selected).find('#create_progress').eq(0).show();

Uncaught TypeError: Cannot read property 'find' of undefined

I wonder if $D.selected was affected somehow? This is the kind of thing a system test (#5316) will help prevent!

Noting this could be linked to #5229

[jywarren]

Yes! It's the same as this: #5229 (comment)

[publiclab-mimi]

I'm currently unable to click to upload or drag an image onto a wiki page. I'm not sure if it's related. I'm not getting an error, just no response no matter how long I let the webpage sit open and "think" about it.

[steviepubliclab]

Same issue here on /air-quality

[publiclab-mimi]

I also tried this post clearing-cache, in a different browser, and on a different computer. Still no image uploading working for me.

…

On May 10, 2019, at 10:02 AM, Stevie ***@***.***> wrote: Same issue here on /air-quality — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5650 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALUKWT6MJCUVOPHAPUAEDH3PUWE77ANCNFSM4HKB2NQA>.

[jywarren]

This was fixed in #5657 for comment image uploading, but the fix didn't apply to wiki page image upload. Checking why now; I believe it is failing on $E.wrap in:

  // wraps currently selected text in textarea with strings a and b
  wrap: function(a,b,args) {
    this.refresh();
    var len = $E.textarea.val().length;

That's here:

plots2/app/assets/javascripts/editor.js

Line 43 in a3e40c5

var len = $E.textarea.val().length;

It's initialized here:

plots2/app/views/editor/_editor.html.erb

Line 39 in a3e40c5

$E.initialize({})

[jywarren]

Yes!!! This changed, re-assigning $E.textarea to fix reply-to-comment functionality:

https://github.com/publiclab/plots2/pull/5321/files#diff-fd61d47ff16a49707d50fa5f9ae7c5f5R32

We need to make an exemption for wiki image upload.

[jywarren]

Filed a fix, which I tested, at #5703!

[jywarren]

Thanks, all!