Sign Up button conflicts with "I'm not a robot" checkbox in the Sign-up modal

[imdhruvgupta]

The " I'm not robot " checkbox overlaps with the sign-up button in the Sign up modal in the desktop view.

[SidharthBansal]

@IshaGupta18 can you please look at this. You did the last PR for these files after which this error has pop up.

[SidharthBansal]

It was working fine before your pr. I think you forget to see the layout of the modal while doing the pr.
Create a pr to fix this too.

[imdhruvgupta]

@SidharthBansal #4634 is also the same issue.

[IshaGupta18]

Let me have a look at this, this wasn't coming in development probably because we were using spamaway there

[jywarren]

Yeah - maybe we can wrap the recaptcha code in a div and give it a fixed height? I think perhaps it's partially because the recaptcha is being pregenerated while the modal is collapsed, so it positions and sizes itself during the hidden state.

…

On Thu, Jan 17, 2019 at 2:03 PM Isha Gupta ***@***.***> wrote: Let me have a look at this, this wasn't coming in development probably because we were using spamaway there — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4643 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJylzYpayX9sUrKGe-tApqOzo-DVDks5vEMjngaJpZM4aGWeC> .

[IshaGupta18]

Yes it could be the reason, let me have a look at it. Thanks @jywarren !

[IshaGupta18]

What do you suggest the fixed height should be @jywarren ? Since it can only be tested in production?

[jywarren]

well, can you count the pixel height of the production version and we'll just fix it at that, maybe +10px?

…

On Thu, Jan 17, 2019 at 2:57 PM Isha Gupta ***@***.***> wrote: What do you suggest the fixed height should be @jywarren <https://github.com/jywarren> ? Since it can only be tested in production? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4643 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJz1bvRseKMbQD3RS8SpmW2DhOVmHks5vENVzgaJpZM4aGWeC> .

[IshaGupta18]

Oh yes, my bad, should have thought about it

[IshaGupta18]

So I was thinking of give the wrapping div a height of about 120px or something, because the div in which the recaptcha occurs is about a 100px high. How does it sound?

[jywarren]

sounds great! Thanks, Isha!

…

On Thu, Jan 17, 2019 at 3:14 PM Isha Gupta ***@***.***> wrote: So I was thinking of give the wrapping div a height of about 120px or something, because the div in which the recaptcha occurs is about a 100px high. How does it sound? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4643 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ44nTYidTNsFVGAE3NxKJFGXD1eIks5vENmKgaJpZM4aGWeC> .

[SidharthBansal]

@dhruvgupta167 thanks for reporting the bug. Sorry I missed to thank you.

[imdhruvgupta]

@dhruvgupta167 thanks for reporting the bug. Sorry I missed to thank you.

@SidharthBansal No need! Just trying to contribute to the organisation.

[SidharthBansal]

@IshaGupta18 please link the pr number here.
Thanks all

[IshaGupta18]

#4672 is the PR for this issue. Thanks a lot everyone! Also, I am sorry for the terrible delay.