Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature code under Sign Up Modal #4322

Closed
SidharthBansal opened this issue Dec 16, 2018 · 8 comments · Fixed by #4635
Closed

Feature code under Sign Up Modal #4322

SidharthBansal opened this issue Dec 16, 2018 · 8 comments · Fixed by #4635
Labels
gsoc in progress more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem rgsoc Rails Girls Summer of Code

Comments

@SidharthBansal
Copy link
Member

As per the gitter chat,
@jywarren asked

But I think we need to show the info text and the notice about open source and code of conduct. Maybe we need a Feature just below the sign up form to be able to add customized content.
It'd be a pretty easy addition, the feature code is one line.

Let's turn this into a first timers only issue @gauravano @jywarren !!!

@SidharthBansal SidharthBansal added this to the OAuth milestone Dec 16, 2018
@grvsachdeva
Copy link
Member

This issue will be proceeded once the feature is created by one of the admins. @jywarren whenever you would be done with the feature please add the name of feature below and we will turn it into FTO. Thanks!

@grvsachdeva grvsachdeva added more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem in progress labels Dec 16, 2018
@SidharthBansal
Copy link
Member Author

SidharthBansal commented Dec 16, 2018 via email

@jywarren
Copy link
Member

jywarren commented Dec 16, 2018 via email

@SidharthBansal SidharthBansal mentioned this issue Dec 18, 2018
20 tasks
@oorjitchowdhary
Copy link
Member

oorjitchowdhary commented Dec 19, 2018

Can you point out the exact line that needs to be added.. I'll make it into a first-timers-only issue
@publiclab/reviewers

@SidharthBansal SidharthBansal added rgsoc Rails Girls Summer of Code gsoc labels Jan 11, 2019
@SidharthBansal
Copy link
Member Author

@jywarren it will be great if you can tell us on this. As you asked for this feature. It is little ambiguous to me.

@SidharthBansal
Copy link
Member Author

You can tell the text we will turn it into fto.

@jywarren
Copy link
Member

Oh, i'm sorry - it looks like it was done here:

2a1f98d

But it looks like it got mistakenly removed here, maybe during a rebase:

4fa3343#diff-476e45acd5b545a090eb0f774aff07dbL78

I'm going to re-add it and close this issue, thanks!! But we could definitely use help with #4634 if you're interested!

@jywarren
Copy link
Member

Submitted fix in #4635 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc in progress more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem rgsoc Rails Girls Summer of Code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants