-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature code under Sign Up Modal #4322
Comments
This issue will be proceeded once the feature is created by one of the admins. @jywarren whenever you would be done with the feature please add the name of feature below and we will turn it into FTO. Thanks! |
I think we can add custom text now as per @jywarren 's suggestion. Later we
can create a button. What do you think?
…On Sun, Dec 16, 2018 at 9:47 PM Gaurav Sachdeva ***@***.***> wrote:
This issue will be proceeded once the feature is created by one of the
admins. @jywarren <https://github.com/jywarren> whenever you would be
done with the feature please add the name of feature below and we will turn
it into FTO. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4322 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ3XXalte4qAMxnx6uPwpIwWHp-I2ks5u5nIUgaJpZM4ZVT9t>
.
|
Yes its possible to add a button inside the feature too, it can be raw
HTML. Great!!!
On Sun, Dec 16, 2018, 11:22 AM Sidharth Bansal <notifications@github.com
wrote:
… I think we can add custom text now as per @jywarren 's suggestion. Later we
can create a button. What do you think?
On Sun, Dec 16, 2018 at 9:47 PM Gaurav Sachdeva ***@***.***>
wrote:
> This issue will be proceeded once the feature is created by one of the
> admins. @jywarren <https://github.com/jywarren> whenever you would be
> done with the feature please add the name of feature below and we will
turn
> it into FTO. Thanks!
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#4322 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AUACQ3XXalte4qAMxnx6uPwpIwWHp-I2ks5u5nIUgaJpZM4ZVT9t
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4322 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJzCcuiwRmaofCowiww6jmm_g_IeUks5u5nMigaJpZM4ZVT9t>
.
|
Can you point out the exact line that needs to be added.. I'll make it into a |
@jywarren it will be great if you can tell us on this. As you asked for this feature. It is little ambiguous to me. |
You can tell the text we will turn it into fto. |
Oh, i'm sorry - it looks like it was done here: But it looks like it got mistakenly removed here, maybe during a rebase: 4fa3343#diff-476e45acd5b545a090eb0f774aff07dbL78 I'm going to re-add it and close this issue, thanks!! But we could definitely use help with #4634 if you're interested! |
Submitted fix in #4635 ! |
As per the gitter chat,
@jywarren asked
Let's turn this into a first timers only issue @gauravano @jywarren !!!
The text was updated successfully, but these errors were encountered: