Integration Tests for Spam Away

[SidharthBansal]

I think we should have a test for this sequence with realistic parameters for spamaway, as it made me uncomfortable that it errored but the tests passed.

see #4209 (comment) and #4209 (comment) for reference.

We need some tests to ensure that the spam away works fine on the localhost.
Let's build it @jywarren.
Refer #4209.

[SidharthBansal]

Refer #3990 for the implemented work.
Spam away is only for the development mode as the reCatcha does not work on the locahost.

[grvsachdeva]

User has option to switch to spamaway in production too?

[SidharthBansal]

No,Jeff created Spam Away just for the development, I guess.
ReCatcha does not work at the development mode.

[grvsachdeva]

Yes, I am aware that recaptcha doesn't work in development and also not on unstable.

[SidharthBansal]

I was not aware of the fact that it does not work on unstable. Thanks @gaurav Sachdeva <sachdeva.gaurav1997@gmail.com> .It solved #4209's some subissue.

…

On Sun, Dec 16, 2018 at 9:19 PM Gaurav Sachdeva ***@***.***> wrote: Yes, I am aware that recaptcha doesn't work in development and also not on unstable. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4321 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ9tzULpppC5-LKSpGfEOBQ6RF1xoks5u5mulgaJpZM4ZVTE2> .

[grvsachdeva]

Hey @SidharthBansal it wasn't working before on unstable but I just tested signup via modal on unstable and identify the items check is coming. So working!

[SidharthBansal]

Yeah, Jeff made some changes and now it is working. Thanks for your help.

…

On Sun, Dec 16, 2018 at 9:25 PM Gaurav Sachdeva ***@***.***> wrote: Hey @SidharthBansal <https://github.com/SidharthBansal> it wasn't working before on unstable but I just tested signup via modal on unstable and identify the items check is coming. So working! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4321 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQyoNJXyOTBKevS5vCrcARQbY6Y4Hks5u5mzwgaJpZM4ZVTE2> .

[SidharthBansal]

@VladimirMikulic @Uzay-G any of you guys want to add tests quickly here?

[SidharthBansal]

Although it is integration test, we can mark them under system test task as integration tests also have similar complexity as the system tests. Who is aiming to solve this? May be someone else apart from you two

[sssash18]

@SidharthBansal I would like to add the test for the case when spamaway text area is not blank.Could I proceed with this?

[VladimirMikulic]

@sssash18 go on :)

[sssash18]

@SidharthBansal @VladimirMikulic @Uzay-G Kindly review the added test

[sssash18]

@SidharthBansal @VladimirMikulic @Uzay-G Are thier any other tests that I can help in adding?

[VladimirMikulic]

@sssash18 thank you for the interest, right now we are focusing on system tests. We could use some help :)

[sssash18]

@VladimirMikulic Let me know how I can help

[VladimirMikulic]

Let's first resolve the Travis, shall we? 😄

[SidharthBansal]

Sure

…

On Fri, Jan 17, 2020 at 9:24 PM Vladimir Mikulic ***@***.***> wrote: Let's first resolve the Travis, shall we? 😄 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4321?email_source=notifications&email_token=AFAAEQ46SM65HG5BCRDQXR3Q6HICHA5CNFSM4GKVGE3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIDQKQ#issuecomment-575682602>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ2MIDTM76J2C3VIHKDQ6HICHANCNFSM4GKVGE3A> .