Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate confirmation email (done) and require confirmation (not yet done) #378

Closed
ebarry opened this issue Feb 29, 2016 · 12 comments
Closed
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration

Comments

@ebarry
Copy link
Member

ebarry commented Feb 29, 2016

Updated: notification complete, extra confirmation remaining

Registered a new user account "liztester" to see what happens.

Relevant URLs

/https://publiclab.org/signup

PublicLab.org username

liztester

Browser, version, and operating system

Chrome Version 48.0.2564.116 (64-bit) Mac OSX 10.11.3

For bug reports, fill out the above template; for feature requests, you can delete the template.

@jywarren
Copy link
Member

Hi, Liz - I don't think we have a confirmation email feature. If you'd like to request we create one, change the name of this issue and perhaps outline what a confirmation email could say. This might also help folks remember their usernames.

@ebarry
Copy link
Member Author

ebarry commented Feb 29, 2016

The confirmation email should include the username that the person just created.
Exact wording TBD, but should take into account or possibly influence the messages shown to people upon their first and second log-ins to the site:

1st visit: (see message in yellow)
1st visit to site

2nd visit: (see message in yellow)
2nd visit to site

@ebarry ebarry changed the title no confirmation email generated upon new user registration generate confirmation email including username upon new user registration Mar 14, 2016
@jywarren jywarren added this to the UI and newcomer onboarding milestone Jan 17, 2018
@jywarren
Copy link
Member

Let's start with just a welcome email! Then move on to a confirmation email.

@jywarren jywarren added the break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration label Jan 17, 2018
@ebarry ebarry mentioned this issue Feb 21, 2018
7 tasks
@ebarry ebarry modified the milestones: UI and newcomer onboarding, Newcomer onboarding Feb 21, 2018
@jywarren
Copy link
Member

Solving in #2241 ! This would then follow and connect with spam solutions.

@grvsachdeva
Copy link
Member

Any help required here @jywarren @ebarry ? Thanks!

@jywarren
Copy link
Member

OK, so the next thought was to require people signing up to click a "this is really me" link in the email to confirm they really own that email. I think this is probably a good idea but defer to @ebarry

@jywarren
Copy link
Member

If they logged in using OAuth, they'd be excepted from this requirement, i guess? @SidharthBansal ?

@SidharthBansal
Copy link
Member

@jywarren yeah we don't send any welcome emails to new users.
Can you please elaborate?
This is new issue to me.

@jywarren
Copy link
Member

We do now, as of #2241 ! 😄

Maybe we should hold off on this for a bit, but the idea is that if users sign up (non-OAuth), they should have to confirm a real email address, otherwise they could sign up with someone else's email, or even have a typo when they initially enter their email.

@SidharthBansal
Copy link
Member

SidharthBansal commented Jul 11, 2018

You mean Email verification. Great feature

@jywarren
Copy link
Member

jywarren commented Jul 11, 2018 via email

@jywarren jywarren changed the title generate confirmation email including username upon new user registration generate confirmation email (done) and require confirmation (not yet done) Sep 17, 2018
@grvsachdeva
Copy link
Member

We now have welcome email and also confirmation email is in WIP. The updated checklist at #3798. Closing this one. Thanks!

cc/ @ebarry @jywarren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration
Projects
None yet
Development

No branches or pull requests

4 participants