Make "Test Digest Email" button on profile page viewable to admins only

[avsingh999]

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Please describe the problem (or idea)

In user profile page there is a Button Test Digest Email. It's not looking good .
add some style

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

Please show us where to look

https://publiclab.org/ profile/user_name

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[jywarren]

this'd be great. It could use the class names `class="btn btn-default"` like the others there. Can you help point at the lines of code that need to be changed as in #3424 ?

…

On Mon, Sep 24, 2018 at 5:28 PM Avkaran Singh ***@***.***> wrote: Please describe the problem (or idea) In user profile page there is a Button Test Digest Email. It's not looking good . add some style [image: button] <https://user-images.githubusercontent.com/25536022/45980082-b2975d80-c06e-11e8-978c-656aff305d38.png> What happened just before the problem occurred? Or what problem could this idea solve? What did you expect to see that you didn't? Please show us where to look https://publiclab.org/ profile/user_name What's your PublicLab.org username? This can help us diagnose the issue: Browser, version, and operating system Many bugs are related to these -- please help us track it down and reproduce what you're seeing! ------------------------------ Thank you! Your help makes Public Lab better! We *deeply* appreciate your helping refine and improve this site. To learn how to write really great issues, which increases the chances they'll be resolved, see: https://publiclab.org/wiki/developers#Contributing+for+non-coders — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3440>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ44cbIYd_cumq0iWETGmMrlMoVkwks5ueU51gaJpZM4W3fRY> .

[SidharthBansal]

I think this button needs to be removed. @ViditChitkara used to test the features in Gsoc. So may be we don't need it now?

[ViditChitkara]

It has got some bugs too. Shouldn't it be available for admins or some smaller grp of users only??

[avsingh999]

@jywarren in this file line 221
https://github.com/publiclab/plots2/blob/1b3cd0802d5a16436602afc373f56e1ae2ade2f1/app/views/users/profile.html.erb

[SidharthBansal]

So instead of changing the style of the button we can display the button only to admins and moderators. We can create nice gci issues for them and their respective tests. Let's see what Jeff says

[SidharthBansal]

Nice catch @avsingh999 we are really looking for hardworking people like you. You opened a lot of bugs thanks for it

[avsingh999]

@SidharthBansal thank you

[avsingh999]

@SidharthBansal @jywarren should i add access group to the button.

[SidharthBansal]

No you don't need to add access button to it.
Instead we need to

1. Write code in the view files that this button is only visible to admins or moderators.
   We don't want this button to be shown to general public.
2. We need to write test that this button is seen by admin
3. We need to write test that this button is seen by moderators
4. We need to write test that this button is not seen by normal users.

[SidharthBansal]

Will you want to work on this?

[avsingh999]

yes I want to work on it

[SidharthBansal]

OK go ahead. This issue is broken into sub issues as listed above. So do things part by part. We highly focus on modularity.
Thanks

[noi5e]

@jywarren I'm an Outreachy applicant. Can you assign me to this issue please? :)

[jywarren]

awesome! Please go ahead! Thanks!

…

On Thu, Oct 8, 2020, 6:48 PM noi5e ***@***.***> wrote: @jywarren <https://github.com/jywarren> I'm an Outreachy applicant. Can you assign me to this issue please? :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3440 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J2OWTA7LIQG4GJN2CDSJY6TLANCNFSM4FW56RMA> .

[noi5e]

Okay, I got the site up and running locally, and it looks like this issue has been taken care of already:

Maybe close this issue? However I did notice that the "More User Info" modal on the Profile page doesn't work in Firefox, so I think I'll make a new issue for that.

[cesswairimu]

Thanks @noi5e, closing this