Invent clever way to trigger notification when a first-timer finishes a pull request

[jywarren]

We have a great set of first-timers-only issues at https://code.publiclab.org, and a welcomebot to thank people when they're successfully closed:

(see #3392 (comment))

We can find closed pull requests where WelcomeBot has responded using this API query:

https://api.github.com/search/issues?o=desc&q=is%3Apr+is%3Aclosed+%22Congrats+on+merging+your+first+pull+request%21%22+user:publiclab&s=updated&type=Issues

But it would be great to trigger some kind of notification to be sent, by email/tweet/slack/chat, so we can be reminded to thank people afterwards! It's hard to keep track of all of the closed issues, so we could use some help with this one.

Can you think of a clever integration to achieve this?

[grvsachdeva]

So, it would be like a thank you message in form of Email or a tweet? People may not mention their twitter handle, so if we wanna be sure that they get our message, mailing them from PL domain would be nice :)

[jywarren]

the WelcomeBot message now asks people for their twitter handle, so the ideal is that this is triggered when they respond to /that/ prompt. But it would still be VERY useful to just see all closed PRs that were that person's first PR, which the above link shows via the API. I just can't think of a simple way to trigger a message of any kind from that API result... :-/

…

On Mon, Sep 24, 2018 at 12:01 PM Gaurav Sachdeva ***@***.***> wrote: So, it would be like a thank you message in form of Email or a tweet? People may not mention their twitter handle, so if we wanna be sure that they get our message, mailing them from PL domain would be nice :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ_fHcX8aWHa3zIWPqNqpP0xmTquJks5ueQGzgaJpZM4W28UK> .

[Souravirus]

Hi @jywarren, can't we ask for their twitter handle when the first-timer open the pull request. So, that we get notified and then later thank them in twitter when the PR gets merged.

[jywarren]

ah, good idea! And good FTO -- have you used first-timers-bot yet? https://github.com/hoodiehq/first-timers-bot the file is under /.github/config.yml

…

On Tue, Sep 25, 2018 at 2:34 AM Sourav Sahoo ***@***.***> wrote: Hi @jywarren <https://github.com/jywarren>, can't we ask for their twitter handle when the first-timer open the pull request. So, that we get notified and then later thank them in twitter when the PR gets merged. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ4qdRNtnqsZ6-ZlSMkcRyCWVwO1Rks5uec5NgaJpZM4W28UK> .

[Souravirus]

Yeah I have used it while creating first-timers issues. I will make a fto issue.

[Souravirus]

@jywarren just wanted to ask if we want to add the message of Twitter handle on the first-timers-issue or the welcome-bot opening message.

[Souravirus]

In my opinion, this message should be on the welcome-bot opening message. what do you think?

[jywarren]

that sounds great. Let's do it!

…

On Tue, Sep 25, 2018 at 2:37 PM Sourav Sahoo ***@***.***> wrote: In my opinion, this message should be on the welcome-bot opening message. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ9HvhojZfaXTnTEVQawzPHKh55wXks5uenfIgaJpZM4W28UK> .

[Souravirus]

@jywarren I have made a new first-timers-issue #3485. Please see this. Just wanted to ask can we make a gci-candidate issue or leave it as a normal first-timers-issue.

[jywarren]

maybe best mark it as fto-candidate and gci-candidate for now... we have so many newcomers it's getting a little tough to manage!

…

On Tue, Sep 25, 2018 at 4:59 PM Sourav Sahoo ***@***.***> wrote: @jywarren <https://github.com/jywarren> I have made a new first-timers-issue #3485 <#3485>. Please see this. Just wanted to ask can we make a gci-candidate issue or leave it as a normal first-timers-issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ0N1qfwgu9hpl8eI0QOMwFF71OTBks5uepkGgaJpZM4W28UK> .

[Souravirus]

Ok I will