Link to New User Profile page broken

[bronwen9]

New user page:
https://publiclab.org/notes/Charlescollins83/03-08-2018/Charlescollins83 is unavailable.

They've made one post at: https://publiclab.org/notes/Charlescollins83/03-08-2018/tvi, which is in the moderation queue.

[jywarren]

Hi, it looks like the profile link is wrong -- where did the link come from? Thanks for reporting! I think if we fix the link to https://publiclab.org/profile/Charlescollins83 we should be good 👍

[bronwen9]

This was a spam author who I wanted to ban: it was linked from the moderator email.

…

On Mar 9, 2018 4:23 PM, "Jeffrey Warren" ***@***.***> wrote: Hi, it looks like the profile link is wrong -- where did the link come from? Thanks for reporting! I think if we fix the link to https://publiclab.org/profile/Charlescollins83 we should be good 👍 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2447 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH8hxe_2YCKa1NOAnhencKanBvC3IKWDks5tcvK-gaJpZM4SilPy> .

[jywarren]

I'm having some trouble finding the wrong link to identify the bad code -- if you could try to see where in the email the link was from we can fix it -- thanks, and no rush!

[jywarren]

Here's one of the templates! https://github.com/publiclab/plots2/blob/master/app/views/admin_mailer/notify_moderators_of_spam.html.erb

[bronwen9]

The email came through the moderators list on March 7, SUbject was: [New Public Lab poster needs moderation] TVI

Content (copy/pasted from email)
First-time poster Charlescollins83 has submitted their first research note!
Please help to approve it or mark it as spam: https://publiclab.org/notes/Charlescollins83/03-08-2018/tvi
Approve or Spam
test
It has the following tags:
User Info

527011
Charlescollins83
charlescollins83@hotmail.com

I'll forward it to you as well. I feel like I've seen this occasionally before. Thanks!

[bronwen9]

Ah! I just clicked on the profile again, and see that it is showing up now (maybe you fixed it?) I am going to go ahead and ban it, thanks!

[bronwen9]

Ohh, wait, scratch that, now I remember that I don't think it's spam after all, but kind of wanted to check the profile to double check. The navigation just got weirder. When I clicked in to the username from the email it worked (and can view profile), but when I tried to click to the profile from the post it shows up as the error. Additionally, I can't reach the research note from the link in the profile.

Update: I approved the note and now the navigation has evolved.. I can link to the profile from the post.. maybe this is just something strange in how approval-pending posts appear?

[jywarren]

Awesome! Found it! I can make a quick first-timers issue to fix it:

plots2/app/controllers/application_controller.rb

Line 136 in 34935fb

flash[:warning] = "First-time poster <a href='#{@node.author.name}'>#{@node.author.name}</a> submitted this #{time_ago_in_words(@node.created_at)} ago and it has not yet been approved by a moderator. <a class='btn btn-default btn-sm' href='/moderate/publish/#{@node.id}'>Approve</a> <a class='btn btn-default btn-sm' href='/moderate/spam/#{@node.id}'>Spam</a>"

[jywarren]

Done! Thanks @bronwen9 -- #2470