inline-map , [map:tag:_tagname_:_latitude_:_longitude] showing incorrect nodes .

[sagarpreet-chadha]

Please describe the problem (or idea)

Tested this here , https://publiclab.org/wiki/test-wiki-page , [map:tag:tagname:latitude:_longitude] is showing incorrect nodes .

It is because we are calling our API in /_leaflet.html.erb which gives all the nearby_nodes using _latitude_ and _longitude and does not consider tagname .

Possible Solutions :

1.) Using the same partial /_leaflet.html.erb and making a query on database and hence showing markers .
2.) Making a new partial and making an API and a model search-helper function and loading blank map and calling API and hence showing markers .

[sagarpreet-chadha]

@jywarren , how should i approach this issue ? Thanks 😄 !

[grvsachdeva]

Hi @sagarpreet-chadha, actually while making this API, I highlighted this issue to @jywarren as mentioned in #1934, as this API has been successful I think we should make a new API which incorporates tag.I would be happy to make API for this if you want help 😅.Thanks

[jywarren]

That would be great, @Gauravano!!! 👍

[jywarren]

Shall we rename this to focus on the API tagging implementation and add some code links to that? Thanks, all!

[jywarren]

Hi @sagarpreet-chadha -- just wanted to know if this is completed now... as it's old. WE may have moved way past it!

[jywarren]

@sagarpreet-chadha just bumping this up! Thank you!!!

[sagarpreet-chadha]

On it 👍 !

[jywarren]

lets also hear from @milaarauja to be sure we're on track here! thanks!!!

…

On Tue, Jan 15, 2019 at 2:46 PM Sagarpreet Chadha ***@***.***> wrote: On it 👍 ! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2254 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ2l0eq4muUe0NaW98SodiHl23Cysks5vDi_mgaJpZM4R7Ljw> .

[jywarren]

Is this still open?

[sagarpreet-chadha]

Hi @jywarren ,
Yes this is solved : you can check here : https://publiclab.org/notes/sagarpreet/01-30-2019/inline-map-testing .
Okay currently inline maps are not showing on /wiki pages but it related to LEL (#5678) . Closing this 😄 !!!

[jywarren]

awesome!!!

…

On Wed, May 8, 2019 at 2:34 AM Sagarpreet Chadha ***@***.***> wrote: Hi @jywarren <https://github.com/jywarren> , Yes this is solved : you can check here : https://publiclab.org/notes/sagarpreet/01-30-2019/inline-map-testing . Okay currently inline maps are not showing on /wiki pages but it related to LEL (#5678 <#5678>) . Closing this 😄 !!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2254 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6JZTXQNGN47TMEXIHBDPUJX6VANCNFSM4EPMXDYA> .