Fix tag suggestions to show all relevant ones (#7338)

* Fixes #7263 At location button to dashboard sidebar

* Fixes #7263 At location button to dashboard sidebar

* Trying new code to fix issue

* feature suggests tags in subscriptions

* removed trailing white space

* changed .each to .select

* changed .each to .select

* resolved error

* resolved error

* Test run

* Test run

* Test run 2

app/models/tag.rb

@@ -407,6 +407,10 @@ def self.graph_data(limit = 250)
     end
   end
 
+  def self.all_tags_by_popularity
+    Tag.all.order('count DESC').select { |tag| !(tag.name.include? ":") }.uniq(&:name).pluck(:name)
+  end
+
   def subscription_graph(start = DateTime.now - 1.year, fin = DateTime.now)
     date_hash = {}
     week = start.to_date.step(fin.to_date, 7).count

app/views/home/subscriptions.html.erb

@@ -42,7 +42,7 @@
     <div class="form-group">
       <div class="row">
         <div class="col-md-7">
-          <input type="text" name="name" class="form-control" placeholder="<%= translation('home.subscriptions.enter_tags') %>" data-provide="typeahead" data-source='["balloon-mapping","thermal-flashlight","spectrometer"]' autocomplete="off" required="required">
+          <input type="text" name="name" class="form-control" placeholder="<%= translation('home.subscriptions.enter_tags') %>" data-provide="typeahead" data-source='<%= Tag.all_tags_by_popularity %>' autocomplete="off" required="required">
         </div>
         <div class="col-md-2 pl-md-1">
           <button type="submit" class="btn btn-primary add-subscriptions"><i class="fa fa-plus fa fa-white"></i> <%= translation('home.subscriptions.add') %></button>