-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert database.yml to previous state #725
Conversation
Code Climate has analyzed commit d3e7429 and detected 0 issues on this pull request. View more on Code Climate. |
I've reverted to exactly the same |
But surprisingly |
I think I know what is going on here Kaustubh, I have fixed it on Rails 5.2.3 upgrade. Just reverting database.yml wont fix our problem. Remember that we have found out that we had been running Travis for production env? So this is kinda related, out test credentials are mismatched. I'll try some stuff here. |
bd51041
to
04ea995
Compare
…mapknitter into kaustubh-nair-patch-3
04ea995
to
08b6de8
Compare
@jywarren @sashadev-sky @kaustubh-nair Pushed this to unstable and fixed it both on Travis and Jenkins. :D Jenkins at: https://jenkins.laboratoriopublico.org/job/Mapknitter-Unstable/109/console |
Awesome! Perfect, shall we merge it?
…On Wed, Jun 26, 2019 at 9:44 AM Álax de Carvalho Alves < ***@***.***> wrote:
@jywarren <https://github.com/jywarren> @sashadev-sky
<https://github.com/sashadev-sky> @kaustubh-nair
<https://github.com/kaustubh-nair> Pushed this to unstable and fixed it
both on Travis and Jenkins. :D
Jenkins at:
https://jenkins.laboratoriopublico.org/job/Mapknitter-Unstable/109/console
Travis at:
https://travis-ci.org/publiclab/mapknitter/builds/550805436?utm_source=github_status&utm_medium=notification
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#725?email_source=notifications&email_token=AAAF6J7MZKJN2QV5FS2KRPDP4NXBTA5CNFSM4HZHZDC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYTSDNY#issuecomment-505881015>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J5EIG34ZY6T7VUQYKDP4NXBTANCNFSM4HZHZDCQ>
.
|
Ah i see you commented in Gitter. Merging then! Thanks!! |
* Fix database.yml for test environment for unstable * Update database.yml.example * Revert database.yml * Update database.yml.example * Using correct config for database.yml
Fixes failing build on jenkins https://jenkins.laboratoriopublico.org/job/Mapknitter-Stable/lastFailedBuild/console
I've reverted it back to https://github.com/publiclab/mapknitter/blob/d1e801b436f47c4fe78c0a7cf9bda1503ce8a44b/config/database.yml.example
Let's see how it goes