Reverse map refresh bug #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/models/map.rb
Outdated
| placed_warpables.each do |warpable| | ||
| count += 1 | ||
| res = warpable.cm_per_pixel | ||
| res = 1 if res.zero? # let's not ever try to go for infinite resolution | ||
| scales << res unless res.nil? | ||
| end | ||
| total_sum = (scales.inject { |sum, n| sum + n }) if scales | ||
| return total_sum / count if total_sum | ||
| average = total_sum/count if total_sum |
There was a problem hiding this comment.
Surrounding space missing for operator /.
|
Code Climate has analyzed commit f523a92 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
jywarren
approved these changes
Jun 13, 2019
chen-robert
pushed a commit
to chen-robert/mapknitter
that referenced
this pull request
Dec 5, 2019
* Reverse map refresh bug * Fix codeclimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #670 (review) (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!