Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rubocop to travis pipelines #661

Closed
wants to merge 1 commit into from

Conversation

alaxalves
Copy link
Member

@alaxalves alaxalves commented Jun 3, 2019

Fixes #548 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codeclimate
Copy link

codeclimate bot commented Jun 3, 2019

Code Climate has analyzed commit 950f02d6 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #661 into main will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #661   +/-   ##
=======================================
  Coverage   41.36%   41.36%           
=======================================
  Files          34       34           
  Lines        1308     1308           
=======================================
  Hits          541      541           
  Misses        767      767
Impacted Files Coverage Δ
app/models/map.rb 39% <100%> (ø) ⬆️

@alaxalves
Copy link
Member Author

Already doing this at #672

@alaxalves alaxalves closed this Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Rubocop with Travis
1 participant