Drag and drop added for images in the sidebar

[divyabaid16]

Fixes #644 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

GIF For the same:

Thanks!

[codeclimate]

Surrounding space missing for operator +.

[codeclimate]

Code Climate has analyzed commit dd041d6 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

View more on Code Climate.

[codecov]

Codecov Report

Merging #645 into main will decrease coverage by 0.12%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   71.27%   71.15%   -0.13%     
==========================================
  Files          32       32              
  Lines        1288     1293       +5     
==========================================
+ Hits          918      920       +2     
- Misses        370      373       +3

Impacted Files	Coverage Δ
app/controllers/images_controller.rb	72.97% <40%> (-2.39%)	⬇️

[divyabaid16]

I tried to add the column position in Warpables but I'm getting the following error:

Can you please help me out @gauravano @jywarren ?
Thanks!

[jywarren]

Hmm, I'm not sure about that error, but maybe googling for the exact phrase with the word "field" especially could help -- it doesn't look like the typical "that column doesn't exist" type error. I was wondering if we could think through what would happen if a warpable belonged to multiple maps. How could we track position? Would we put the position field in the join table, something like image_to_map.position, so each map could have a different ordering? Or what other ideas do you have? Thanks!!!

…

On Tue, May 28, 2019, 9:28 AM Divya Baid ***@***.***> wrote: I tried to add the column position in Warpables but I'm getting the following error: [image: Selection_163] <https://user-images.githubusercontent.com/32747809/58481634-6743ca80-817a-11e9-9120-eabb2b7ceb0f.png> Can you please help me out @gauravano <https://github.com/gauravano> @jywarren <https://github.com/jywarren> ? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#645?email_source=notifications&email_token=AAAF6J4LRH7JDWYGZCGKIMLPXUXO5A5CNFSM4HQBAM3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMDZUA#issuecomment-496516304>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J7SOGYSZHUE34JR3ODPXUXO5ANCNFSM4HQBAM3A> .

[divyabaid16]

@jywarren

Here, after drag and drop of the table rows, I tried to get the order in which they are present now,
it can be seen in

Processing by ImagesController#sort as */*
  Parameters: {"warpable"=>["100", "101", "99"]}

And, after getting the parameters, I updated the position, i.e a new colunm and displayed the table in sorted order of position according the the way, the params are sorted.

And regarding, warpable belonging to multiple map, I think while doing this, id of the particular map was recorded and changes was made only to the images in that map.

Thanks!

[divyabaid16]

My error for this comment is solved.

I had cleaned all the tables and migrated it once again.

Thanks for your help @jywarren !

[jywarren]

I guess this is a separate discussion then, about images-belonging-to-many-maps, but if we did do this, i think it may be worth putting the position in the join table, or each time reordering happens, it could rearrange other maps too! See here for reference -- does this make sense? https://guides.rubyonrails.org/association_basics.html#the-has-and-belongs-to-many-association Thanks!

…

On Tue, May 28, 2019 at 10:11 AM Divya Baid ***@***.***> wrote: My error for this comment <#645 (comment)> is solved. I had cleaned all the tables and migrated it once again. Thanks for your help @jywarren <https://github.com/jywarren> ! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#645?email_source=notifications&email_token=AAAF6JZRGQOCI6GATA3L6DDPXU4N5A5CNFSM4HQBAM3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWMIACI#issuecomment-496533513>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6JYOMEDK5A24CSTQACDPXU4N5ANCNFSM4HQBAM3A> .

[divyabaid16]

I got your point @jywarren , I will try it now.
Thanks!

[divyabaid16]

Hi @jywarren @gauravano @sashadev-sky
I'm still not able to reorder the images after the page is refreshed even though I had ordered the images in the database based on the position.
Can you please help me out with this?

Thanks!

[sashadev-sky]

@divyabaid16 I made a commit suggestion that resolves the problem! And this is done client side so it won't effect other maps.

[sashadev-sky]

My commit suggestion also still works if you delete the update to the feeds_controller:

@warpable = Warpable.sort_by('position')

and in the images_controller can delete:

 @warpable = Warpable.order('position')    
    respond_to do |format|
      format.json { head :no_content }
    end

Although i'm wondering about the respond_to block, is this just a RESTful way to handle not responding any content so should be kept? Is this a rails 3 practice or still the standard for newer versions?

[divyabaid16]

Oh, I guess I had added that lines to feed_controller by mistake.
It has nothing to do with that.

Thanks!

[divyabaid16]

Thank you @sashadev-sky for your changes suggested :)

I'm attaching the working GIF

@jywarren @gauravano can you please review this now?

Thanks!

[divyabaid16]

The test is failing because of too many lines in image_controller.

[sashadev-sky]

@divyabaid16 try rebasing and testing it - because its throwing a server error for me now!

[divyabaid16]

I have created a new pull request #670
Thanks!