-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving docker #429
Closed
Closed
Improving docker #429
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dd6756b
Shortening docker image in ~30%
alaxalves ad3bc24
Caching bundle, gathering env variables and using newer sintax
alaxalves d54686b
Creating startup script and env file
alaxalves a7ef7a7
Improving travis CI configuration
alaxalves a1049e3
Loading assets in production env
alaxalves 7959f7b
Allow uglifier to interpret ES6
alaxalves 19ada8e
Fix start command
icarito d620512
Fix travis script
icarito 935be16
Tweak travis script
icarito 5c72ffe
Add delay
icarito 9d9f3ea
Revert assets changes
icarito f6372c9
Return to Mysql5.7
icarito efc01e2
Tweak travis script
icarito 2af8a5d
Fix make redeploy-container command
icarito 7c49d70
Add db migrate and precompile step.
icarito 4b4c64e
Add bower install to Makefile
icarito 3d12cad
Clean after docker run. Avoid one bower run.
icarito 340a5d3
Merge branch 'main' into improving-docker
icarito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,26 @@ | ||
db: | ||
image: mysql:5.7 | ||
environment: | ||
- MYSQL_DATABASE=mapknitter | ||
- MYSQL_USER=mapknitter | ||
- MYSQL_PASSWORD=mapknitter | ||
- MYSQL_RANDOM_ROOT_PASSWORD=true | ||
volumes: | ||
- ../mysql:/var/lib/mysql | ||
web: | ||
build: . | ||
command: ./start.sh | ||
environment: | ||
- RAILS_ENV=production | ||
volumes: | ||
- ./:/app | ||
ports: | ||
- "127.0.0.1:3000:3000" | ||
links: | ||
- db | ||
version: '3.3' | ||
services: | ||
db: | ||
container_name: db | ||
image: mysql:5.6 | ||
env_file: | ||
- mapknitter.env | ||
volumes: | ||
- /srv/mapknitter_priv1/mk1_database:/var/lib/mysql | ||
web: | ||
container_name: web | ||
build: . | ||
env_file: | ||
- mapknitter.env | ||
volumes: | ||
- .:/app | ||
- bundle_cache:/usr/local/bundle | ||
- bower_cache:/app/public/lib | ||
ports: | ||
- 3000:3000 | ||
depends_on: | ||
- db | ||
|
||
volumes: | ||
bundle_cache: | ||
bower_cache: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
MYSQL_DATABASE=mapknitter | ||
MYSQL_USER=mapknitter | ||
MYSQL_PASSWORD=mapknitter | ||
MYSQL_RANDOM_ROOT_PASSWORD=true | ||
RAILS_ENV=production |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, i think we might need this for the export resolution setting, can we test this out on a container before merging?