Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDAL export container #349

Closed
wants to merge 2 commits into from
Closed

Conversation

icarito
Copy link
Member

@icarito icarito commented Feb 20, 2019

I've created a Dockefile to define an image of GDAL 2.4.1 + Imagemagick + Ruby 2.5.

**You can try this ** by getting the already-built image from Docker-hub!

run docker run icarito/gdal_ruby_imagemagick:buster

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
  • pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

@icarito
Copy link
Member Author

icarito commented Feb 20, 2019

This PR seems to have some artifacts of another branch, I'll clean it up, sorry!

@jywarren
Copy link
Member

What do you think the best minimal interface is to connect export.rb to the outside world? I'd guess it's probably going to be more efficient than Rails to have a more minimal way to initiate commands to export.rb and provide HTTP progress responses as it runs (say, static JSON files with status).

@jywarren
Copy link
Member

Also, I wonder if you could try setting up the container without the Rails app but with minitest, so we can run the tests from /test/unit/exporter_test.rb (from #341) on this stand-alone version of the exporter?

@jywarren
Copy link
Member

jywarren commented Feb 20, 2019

Connecting back to https://github.com/googleapis/google-cloud-ruby from the resources issue in #296, which may be a good template for a cloud service in Ruby.

(update - oh that's just a client library... i was thinking of something else. But we should see what the best-practice way to host a cloud service on Ruby is!)

@jywarren
Copy link
Member

@jywarren
Copy link
Member

Yes! The Hello World app is a very basic one-file Sinatra application -- sinatra, i guess, then!

@jywarren
Copy link
Member

@icarito icarito force-pushed the gdal_export_container branch from 7cd5e25 to 3a6dd2c Compare February 21, 2019 06:17
@icarito icarito force-pushed the gdal_export_container branch from 79a8c3d to 3a6dd2c Compare March 26, 2019 05:43
@icarito
Copy link
Member Author

icarito commented Mar 26, 2019

Hi @jywarren I've made a Sinatra app that receives a posted warpable.json file and parses it, but I need some directions on how to trigger https://github.com/publiclab/mapknitter-exporter or even better if it could parse the json file itself ;-)

@jywarren
Copy link
Member

Moving to publiclab/mapknitter-exporter-sinatra#1

@jywarren jywarren closed this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants