Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send patch for new LEL library feature . #282 #283

Merged
merged 4 commits into from
Nov 26, 2018
Merged

Send patch for new LEL library feature . #282 #283

merged 4 commits into from
Nov 26, 2018

Conversation

sagarpreet-chadha
Copy link
Contributor

Fixes #282 !

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
  • pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

@ghost ghost added the in progress label Nov 17, 2018
@ghost ghost removed the in progress label Nov 19, 2018
@ghost ghost added the in progress label Nov 19, 2018
@jywarren
Copy link
Member

Hmm, what's the error here?

@sagarpreet-chadha
Copy link
Contributor Author

screenshot 2018-11-24 at 4 19 22 pm

@sagarpreet-chadha
Copy link
Contributor Author

Resolved now 👍 !

@jywarren jywarren merged commit a0adafc into publiclab:main Nov 26, 2018
@ghost ghost removed the in progress label Nov 26, 2018
@jywarren
Copy link
Member

Awesome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sagarpreet-chadha sagarpreet-chadha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagarpreet-chadha @jywarren