Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md #244

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Update Readme.md #244

merged 1 commit into from
Jan 12, 2018

Conversation

H1manshu21
Copy link
Contributor

@H1manshu21 H1manshu21 commented Jan 6, 2018

Just a space for identifying syntax

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
  • pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

Just a space for identifying syntax
@jywarren
Copy link
Member

jywarren commented Jan 8, 2018

Thank you very much! We're waiting on another fix before tests will start running properly again, but will pull in your fix when that's done!

We'd love your help with another project if youre interested!

https://publiclab.github.io/community-toolbox/#r=all

@H1manshu21
Copy link
Contributor Author

Yeah I will look into it and wait for another fix and then I will pull it when this fix is done 👍

@jywarren jywarren closed this Jan 12, 2018
@jywarren jywarren reopened this Jan 12, 2018
@jywarren
Copy link
Member

OK, re-running now!

@jywarren jywarren merged commit 8b47537 into publiclab:master Jan 12, 2018
@jywarren
Copy link
Member

Hooray! Thanks a lot!

@H1manshu21 H1manshu21 deleted the patch-1 branch January 13, 2018 04:20
@H1manshu21
Copy link
Contributor Author

You are welcome and in future, I want to do more @jywarren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants