Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 method to fetch users on spam management dashboard (no interface yet) #1811

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

PeculiarE
Copy link
Contributor

@PeculiarE PeculiarE commented Aug 9, 2022

Fixes #1810

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Aug 9, 2022

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2022

Code Climate has analyzed commit b0e8d77 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1811 (b0e8d77) into main (51e082c) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
+ Coverage   67.27%   67.44%   +0.17%     
==========================================
  Files          40       40              
  Lines        1314     1321       +7     
==========================================
+ Hits          884      891       +7     
  Misses        430      430              
Impacted Files Coverage Δ
app/controllers/spam_controller.rb 100.00% <100.00%> (ø)

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done, thank you @PeculiarE !!!

@jywarren jywarren merged commit cc2c14a into publiclab:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create endpoints for fetching users on the spam dashboard page
2 participants