Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 add status columns to maps and users tables #1753

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

PeculiarE
Copy link
Contributor

@PeculiarE PeculiarE commented Jun 8, 2022

Fixes #1752

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Jun 8, 2022

@codeclimate
Copy link

codeclimate bot commented Jun 8, 2022

Code Climate has analyzed commit 3e69c08 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1753 (f6dd845) into main (57c6947) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f6dd845 differs from pull request most recent head 4a1b58f. Consider uploading reports for the commit 4a1b58f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   63.47%   63.50%   +0.03%     
==========================================
  Files          39       39              
  Lines        1180     1181       +1     
==========================================
+ Hits          749      750       +1     
  Misses        431      431              
Impacted Files Coverage Δ
app/controllers/maps_controller.rb 87.06% <100.00%> (+0.11%) ⬆️

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @PeculiarE!! I really like the emoji commits.

@PeculiarE
Copy link
Contributor Author

PeculiarE commented Jun 8, 2022

Thank you @TildaDares....They do look cool, right? 😄

You can get them by running "npx git-cz" on your command line instead of the usual "git commit -m ..." whenever u want to write a commit message. You'd be asked to install the package (globally) the first time you do so.

@jywarren jywarren merged commit a817a4d into publiclab:main Jun 10, 2022
@jywarren
Copy link
Member

Very nice, thank you @PeculiarE and thanks @TildaDares !!

@jywarren
Copy link
Member

I love the emoji too! 🌟

@PeculiarE PeculiarE self-assigned this Jun 29, 2022
PeculiarE added a commit to PeculiarE/mapknitter that referenced this pull request Jul 6, 2022
* chore: 🤖 add status columns to maps and users tables

* style: 💄 remove extra indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create status columns on maps and users tables
3 participants