Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix front page map for new LEL version #1266

Merged
merged 4 commits into from
Apr 21, 2020
Merged

fix front page map for new LEL version #1266

merged 4 commits into from
Apr 21, 2020

Conversation

jywarren
Copy link
Member

Fixes #1263 !

@codeclimate
Copy link

codeclimate bot commented Apr 21, 2020

Code Climate has analyzed commit b1023c7 and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren
Copy link
Member Author

NameError: undefined local variable or method `region' for #<ActionDispatch::Routing::Mapper:0x0000000007eb5238>
/home/travis/build/publiclab/mapknitter/config/routes.rb:77:in `block (2 levels) in <main>'

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #1266 into main will increase coverage by 31.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1266       +/-   ##
===========================================
+ Coverage   41.92%   72.92%   +31.00%     
===========================================
  Files          40       40               
  Lines        1579     1400      -179     
===========================================
+ Hits          662     1021      +359     
+ Misses        917      379      -538     
Impacted Files Coverage Δ
app/controllers/front_ui_controller.rb 74.28% <100.00%> (+31.42%) ⬆️
app/models/user.rb 100.00% <0.00%> (+3.57%) ⬆️
app/models/map.rb 93.54% <0.00%> (+3.87%) ⬆️
app/helpers/application_helper.rb 50.00% <0.00%> (+20.58%) ⬆️
app/controllers/application_controller.rb 88.88% <0.00%> (+22.22%) ⬆️
app/controllers/sessions_controller.rb 32.91% <0.00%> (+32.91%) ⬆️
app/controllers/maps_controller.rb 85.47% <0.00%> (+47.86%) ⬆️
app/controllers/annotations_controller.rb 59.25% <0.00%> (+59.25%) ⬆️
app/controllers/images_controller.rb 76.54% <0.00%> (+76.54%) ⬆️
... and 8 more

@jywarren jywarren merged commit cb9eb11 into main Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front page map not loading
1 participant