Fix broken tests #1001
Merged
Fix broken tests #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit e8da2c3 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
=========================================
+ Coverage 73.12% 73.7% +0.57%
=========================================
Files 40 40
Lines 1388 1388
=========================================
+ Hits 1015 1023 +8
+ Misses 373 365 -8
|
|
No worries, Thanks @sashadev-sky |
This was referenced Sep 10, 2019
Closed
jywarren
approved these changes
Sep 10, 2019
|
Great! Thank you!!! |
|
Hooray! Super work! |
chen-robert
pushed a commit
to chen-robert/mapknitter
that referenced
this pull request
Dec 5, 2019
* h * h * fix broken tests * fix * fix click capybara * add parentheses * click_on * fix image placement system test * put back selenium for travis * use old driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #777 (<=== Add issue number here)
prereq to #959
#1003 and update in system test to fix image placement system test (@cesswairimu sorry I think we made edit at same time! this PR also fixes the other tests to pass travis)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/mapknitter-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!