-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable/disable editing functionality needed for collaborative image placement #893
Comments
@jywarren @sashadev-sky what do you think? |
related issue: #804 |
Yeah I've been visualizing like a translucent kind of lock icon on the map in a corner let me try to photoshop a pic real quick |
The lock idea looked weird :/ The only reasonable thing I came up with is: We could remove everything under "license" and write "you are viewing this map in live editing mode". And admin or map owner can click on the green dot to turn off live editing and the box will collapse into something the size of the "write message" area, and say "Live editing mode is off" and dot will turn red. The content under "license" will then show up again. |
That makes sense. I think we should also remove the upload, post, download etc. Functionality as well--actually everything where a user might be able to edit the map. What do you think? |
@jywarren any ideas on this? Should we make it a first-timer-only issue? |
Any updates on this? |
hi! http://publiclab.org/chat could be a good format for a chat popup or embed. What about a "live editing" switch like this? Would it be on by default? Would it be on permanently for anonymous maps? |
Seems like a good idea! I was thinking of keeping a field in map table "is_editable" or something. I think it should be on by default. The button idea is great though. I'll make a first timer issue for this. |
awesome!
…On Wed, Aug 14, 2019 at 2:56 PM Vidit ***@***.***> wrote:
Seems like a good idea! I was thinking of keeping a field in map table
"is_editable" or something. I think it should be on by default. The button
idea is great though. I'll make a first timer issue for this.
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#893?email_source=notifications&email_token=AAAF6J7FH7IPB7GWVPKISB3QERIL7A5CNFSM4IH7F6PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4JYPNI#issuecomment-521373621>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J44ZXRBSTUYIZ3BMXDQERIL7ANCNFSM4IH7F6PA>
.
|
A follow up of #805 , we'll require an enable/disable button which will have the capability to enable or disable synchronous editing with multiple users on a map. This button should only be shown to the author somewhere on the sidebar:-
![Screenshot 2019-07-30 at 11 52 45 PM](https://user-images.githubusercontent.com/22616017/62154816-2bb5b000-b325-11e9-96b2-c8b2f185fe0c.png)
We may store a field in the map model like "is_enabled" or something which could be used as a check as to whether changes be accepted from a foreign user or not.
The text was updated successfully, but these errors were encountered: