Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "view only" map page #761

Closed
jywarren opened this issue Jun 27, 2019 · 6 comments · Fixed by #777
Closed

New "view only" map page #761

jywarren opened this issue Jun 27, 2019 · 6 comments · Fixed by #777

Comments

@jywarren
Copy link
Member

So building on the new designs in #743 we're looking to make a new "view only" page that is loaded when you click on a map. The URL might be /m/map-name, and it'd look like page 17 of this mockup doc: https://docs.google.com/presentation/d/1TCZoTfuhamRVrUak8aDgqJAwSgyhRtZg2Pgacl2_4zc/edit#slide=id.g4f12792b5d_0_0

imageimage

@cesswairimu what do you think? Not everything is in place yet to make it happen 100%, but we can make a new template, use the same code as in the "embed" view, which seems to use the show template?

def embed
@map.zoom ||= 12
@embed = true
render template: 'maps/show'
end

In any case it's got a white band above it but it is supposed to be a view-only map: https://mapknitter.org/embed/cranston-test and it basically works! So, this would be the top map in this mockup.

Also, we used to have a page for this kind of of view-only here: https://github.com/publiclab/mapknitter/blob/main/app/views/map/view.html.erb so maybe that could now be deleted or recycled?

What do you think, @cesswairimu ?

@jywarren
Copy link
Member Author

Also, your new front page should be live here shortly, i think: http://mapknitter-stable.laboratoriopublico.org/front-page

@cesswairimu
Copy link
Collaborator

Looks good @jywarren, I will start working on it and will let you know if something comes up

@jywarren
Copy link
Member Author

Great!!!

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jun 27, 2019

Well good news the '/front-page' url is now working on the stable server. Bad news my css is somehow not working http://mapknitter-stable.laboratoriopublico.org/front-page 🤔 beats me since this was working fine on unstable http://mapknitter-unstable.laboratoriopublico.org/front-page ...working to fix this asap

@cesswairimu
Copy link
Collaborator

Sorry, false alarm, Its fine maybe I tried before the build was finished

@jywarren
Copy link
Member Author

jywarren commented Jun 27, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants