-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "view only" map page #761
Comments
Also, your new front page should be live here shortly, i think: http://mapknitter-stable.laboratoriopublico.org/front-page |
Looks good @jywarren, I will start working on it and will let you know if something comes up |
Great!!! |
Well good news the '/front-page' url is now working on the stable server. Bad news my css is somehow not working http://mapknitter-stable.laboratoriopublico.org/front-page 🤔 beats me since this was working fine on unstable http://mapknitter-unstable.laboratoriopublico.org/front-page ...working to fix this asap |
Sorry, false alarm, Its fine maybe I tried before the build was finished |
Hmm, yes, i also saw the CSS not loading initially ... not sure why! Glad
it's working now though!
…On Thu, Jun 27, 2019 at 1:31 PM Cess ***@***.***> wrote:
Well good news the '/front-page' url is now working on the stable server.
Bad news my css is somehow not working
http://mapknitter-stable.laboratoriopublico.org/front-page 🤔 beats me
since this was working fine on unstable
http://mapknitter-unstable.laboratoriopublico.org/front-page...working to
find fix this asap
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#761?email_source=notifications&email_token=AAAF6J4O7S6XH4Z3BXIVHMDP4T2OJA5CNFSM4H35Y562YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYX2PKY#issuecomment-506439595>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J5Q4UTWA77YALLTFZ3P4T2OJANCNFSM4H35Y56Q>
.
|
So building on the new designs in #743 we're looking to make a new "view only" page that is loaded when you click on a map. The URL might be
/m/map-name
, and it'd look like page 17 of this mockup doc: https://docs.google.com/presentation/d/1TCZoTfuhamRVrUak8aDgqJAwSgyhRtZg2Pgacl2_4zc/edit#slide=id.g4f12792b5d_0_0@cesswairimu what do you think? Not everything is in place yet to make it happen 100%, but we can make a new template, use the same code as in the "embed" view, which seems to use the
show
template?mapknitter/app/controllers/maps_controller.rb
Lines 83 to 87 in a671852
In any case it's got a white band above it but it is supposed to be a view-only map: https://mapknitter.org/embed/cranston-test and it basically works! So, this would be the top map in this mockup.
Also, we used to have a page for this kind of of view-only here: https://github.com/publiclab/mapknitter/blob/main/app/views/map/view.html.erb so maybe that could now be deleted or recycled?
What do you think, @cesswairimu ?
The text was updated successfully, but these errors were encountered: