rake db:migrate does not work

[kaustubh-nair]

While running migrations for the first time, the migrations fail. A workaround for this is to use rake db:setup but it's a good idea to have clean migration files.

== 20091016214109 CreateMaps: migrating =======================================
-- create_table(:maps)
rake aborted!
StandardError: An error has occurred, all later migrations canceled:

Mysql2::Error: BLOB, TEXT, GEOMETRY or JSON column 'styles' can't have a default value: CREATE TABLE `maps` (`id` int(11) auto_increment PRIMARY KEY, `name` varchar(255) DEFAULT '', `lat` decimal(20,10) DEFAULT 0, `lon` decimal(20,10) DEFAULT 0, `zoom` decimal DEFAULT 0.02, `version` int(11) DEFAULT 1, `password` varchar(255) DEFAULT '', `styles` text DEFAULT '', `created_at` datetime, `updated_at` datetime) ENGINE=InnoDB
/h

[alaxalves]

Is this on main branch?

[kaustubh-nair]

Yes its on the main branch On Jun 17, 2019 6:26 PM, Álax de Carvalho Alves <notifications@github.com> wrote: Is this on main branch? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#703?email_source=notifications&email_token=AHGMLDDGCF3IYR2FUURVEM3P26CYLA5CNFSM4HYQZZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3CO5Q#issuecomment-502671222>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHGMLDCSQFHSKU3DFPUXF4TP26CYLANCNFSM4HYQZZVA>.

[alaxalves]

Weird, so this might be coming from main.

[kaustubh-nair]

I think the problem here is with some specific migration file. Because here I can run db:migrate after deleting all the migrations. But it doesn't work on rails-5

[cesswairimu]

Which branch could I pull to replicate this? @alaxalves

[kaustubh-nair]

Hi @cesswairimu
This is a problem on the main branch

[alaxalves]

Has this been fixed? @kaustubh-nair @cesswairimu

[jywarren]

Hi all, what's the latest with this? Thank you!

[grvsachdeva]

Solved in #891. @kaustubh-nair @alaxalves please verify. Thank you!

[kaustubh-nair]

Reopening this because I'm still facing this. The error is the same as mentioned above
I think there is something wrong with the create_maps migration? To reproduce it, drop database, create it, and run migrations
@publiclab/mapknitter-reviewers

[jywarren]

Aha, so @sashadev-sky was addressing this in #959 but actually we should not edit migrations in the past -- they're kind of like version tracking... and any migration already run on a live instance of the app should be considered permanent. Any changes should be added to a new migration - which is why they have timestamps. Does that make sense? So that means these changes to old migrations will cause trouble in any live instance of the app:

https://github.com/publiclab/mapknitter/pull/959/files#diff-1bb55a2824cab57e594057f2563e58a9L8

But! There is a solution. We can add/remove defaults and make changes using this syntax:

https://github.com/publiclab/plots2/blob/b6d5089c5ac3b80ef48481a6753f39b8dc0812ca/db/migrate/20180220180926_add_default_value_to_comment_status.rb#L3

So, instead of those migration changes, let's make all the necessary changes in a new migration with a new timestamp. Then people will be able to build a dev database from it with rake db:setup.

Does that work for folks? Thank you!