Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of multiple images to export #659

Open
2 tasks
divyabaid16 opened this issue Jun 3, 2019 · 7 comments · May be fixed by #693
Open
2 tasks

Selection of multiple images to export #659

divyabaid16 opened this issue Jun 3, 2019 · 7 comments · May be fixed by #693

Comments

@divyabaid16
Copy link
Contributor

I would like to work on the following:

  • The user can select multiple images to export via checkbox.
  • The user can select the option to get the images via email after the export is completed.

Thanks!

@jywarren
Copy link
Member

jywarren commented Jun 3, 2019 via email

@divyabaid16
Copy link
Contributor Author

Yes, this is in the sidebar.

@divyabaid16
Copy link
Contributor Author

Hey @sashadev-sky would you like to give your views on this?
What has been done and what has to be done?

As I can see from a huge discussion going on at #326 #298 that we have a huge exporting system implemented. I took some time to understand the process. Jeff has explained that in a very good manner :)

As far as I have understood, we can download a single image and the export is for all the images. We have to implement a system to select some images and export them to all the formats?
Please let me know wher ever I am wrong.

And the export was not working for me in the localhost. Can you tell me the reason for that?

Thanks!

@sashadev-sky
Copy link
Member

@divyabaid16 Its not working just yet but it should be really soon! I am currently working on getting the json data out of the upstream library and making ajax request publiclab/Leaflet.DistortableImage#286

@divyabaid16
Copy link
Contributor Author

So, should I work on multiple image export later?
Till that I can work on some other issue.
Thanks!

@divyabaid16
Copy link
Contributor Author

I will start with the UI part after publiclab/Leaflet.DistortableImage#286 is merged.
Thanks!

@divyabaid16 divyabaid16 linked a pull request Jun 13, 2019 that will close this issue
5 tasks
@divyabaid16
Copy link
Contributor Author

@sashadev-sky @jywarren please review the PR #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants