Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required Ruby version in README instructions #412

Closed
coreytegeler opened this issue Mar 18, 2019 · 3 comments
Closed

Update required Ruby version in README instructions #412

coreytegeler opened this issue Mar 18, 2019 · 3 comments

Comments

@coreytegeler
Copy link
Contributor

coreytegeler commented Mar 18, 2019

Towards the bottom of the Prerequisites section of the README it is instructing to "install version 2.1.2 of Ruby" while MapKnitter 2 is currently using 2.4.4

Screen Shot 2019-03-18 at 10 37 52 AM

Though this seems like an open-and-shut case, this is my first time attempting to contribute here so I would like a response to confirm this does indeed need to be fixed and I am not missing something. If so, I'd be happy to claim the issue myself and can fix right away and test my first pull request.

Thanks!

@welcome
Copy link

welcome bot commented Mar 18, 2019

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@grvsachdeva
Copy link
Member

hey @coreytegeler, nice catch and sure, go ahead. Thanks!

@coreytegeler
Copy link
Contributor Author

Thank you Gaurav, I've just put in a pull request #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants