Refactor bbox() function's ActiveRecord query to new Rails syntax

[first-timers]

This issue is reserved for applicants to Public Lab’s Providence code fellowship. Please feel free to help applicants, but if you are looking for a first-timers-issue of your own and are not applying for the position, please see our coding Welcome Page at https://code.publiclab.org.

Applicants - upon completion (when your pull request is merged), please include the link to this issue in your application at https://publiclab.org/pvd.

---

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• 📝 Update the file app/models/map.rb in the mapknitter repository (press the little pen Icon) and edit the line as shown below.

To get help installing the application on your computer, see the project README and get help at #307

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -68,8 +68,8 @@ def anonymous?
     self.author == "" || self.user_id == 0
   end
 
-  def self.bbox(minlat,minlon,maxlat,maxlon)
-    Map.find :all, :conditions => ['lat > ? AND lat < ? AND lon > ? AND lon < ?',minlat,maxlat,minlon,maxlon]
+  def self.bbox(minlat, minlon, maxlat, maxlon)
+    Map.where(['lat > ? AND lat < ? AND lon > ? AND lon < ?', minlat, maxlat, minlon, maxlon])
   end
 
   def exporting?

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[labseven]

Hello, I would like to take this issue.

Update: I made the change, but running rake test has one error.

gdal2tiles.py -k --s_srs EPSG:3857 -t "saugus-landfill-incinerator" -g "AIzaSyAOLUQngEmJv0_zcG1xkGq-CXIPpLQY8iQ" /home/newsch/Documents/sw/kevin/mapknitter/public/warps/saugus-landfill-incinerator/saugus-landfill-incinerator-geo.tif /home/newsch/Documents/sw/kevin/mapknitter/public/tms/saugus-landfill-incinerator/
Traceback (most recent call last):
  File "/usr/bin/gdal2tiles.py", line 2436, in <module>
    main()
  File "/usr/bin/gdal2tiles.py", line 2433, in main
    gdal2tiles.process()
  File "/usr/bin/gdal2tiles.py", line 478, in process
    self.generate_metadata()
  File "/usr/bin/gdal2tiles.py", line 1155, in generate_metadata
    f.write( self.generate_tilemapresource())
  File "/usr/bin/gdal2tiles.py", line 1553, in generate_tilemapresource
    for z in range(self.tminz, self.tmaxz+1):
TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'
F
====================================================================================================
test/unit/exporter_test.rb:38:in `block in <class:ExporterTest>'
Failure: test_isolated_exporter_lib(ExporterTest): <false> is not true.
====================================================================================================

[jywarren]

Hello, sorry this took a while, but I've posted on BountySource the stipend that was offered on this issue: https://www.bountysource.com/issues/73946089-refactor-bbox-function-s-activerecord-query-to-new-rails-syntax

Please claim it by clicking that link. Thanks!

[jywarren]

Oh sorry @labseven -- this message was for you, but i see you don't get notifications from this issue:

Hello, sorry this took a while, but I've posted on BountySource the stipend that was offered on this issue: https://www.bountysource.com/issues/73946089-refactor-bbox-function-s-activerecord-query-to-new-rails-syntax

Please claim it by clicking that link. Thanks!

[jywarren]

@labseven just checking if you got my message? Thanks!

[grvsachdeva]

Hey @jywarren, can we close this issue now?